-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth v2 #4
Comments
@slakbal It appears this may not be as difficult as originally thought. Updates to some fields and possibly the response with the access token: |
@upwebdesign hey there. Yeah I have a project running on this so still need to get to that sooner than later, but struggling a bit with finding time. Will see if I can make some time soon to tackle it. If you have already some ideas of how to implement it, it would help with the time issues :) |
@slakbal I asked this question via LogMeIn email support:
And their answer:
The migration, should you stick with Direct Login, looks to be fairly straight forward. This is great news from a time perspective. I will continue to assess. |
Cool... yeah will start to look at migrating everything to v2 auth soon. |
@slakbal I just want to make sure you are aware the Legacy OAuth authentication APIs will stop working October 1st, 2019. This is from an email I received Jan 30th. Sample curl post for Direct Login with oAuth v2:
Documentation: Let me know if you have questions. I will see if I can find time to get a pull request created for this update. |
|
Oh I see now this was merged, but I installed with composer and it is not updated. |
@GalBrigitta it sounds like you required
|
@slakbal I see there have been changes to the code in |
@slakbal Seems the current Proposed solution is to require |
@upwebdesign a new release would be great, I can also help with testing. Anyway I reported an issue, do you think you could help? |
@GalBrigitta I am not the owner of this project nor do I have the ability to publish releases. We can create forks and provide pull requests. |
@GalBrigitta @upwebdesign - since the last week I've been working on a new release with OAuth2 and will soon start to commit to the |
Hey @upwebdesign - on the above, can you please check if the access_token (bearer token) that you receive back from the direct login method actually works in the v2 API via the documentation? It doesn't want to work on my side. You can test if it work directly in the documentation. Maybe I'm doing something wrong. Please let me know, since I want to avoid the standard OAuth redirect login and approval flow and want to keep the API integration fully automated and transparent. Thanks! |
No worries, it was my damn developer account on the dev portal that isn't allowing authentication. the production account is working fine. |
@slakbal, thanks for getting back on the wagon with this. I have not had the time to dive in, but at some point I will need to make the switch myself. I am loaded with another project at the moment and trying to fit in time for the project that your package uses. Once I get there I will keep you informed of any findings and contribute all that I can at that time. Thanks again for the dialog. |
Hi @slakbal, I can help with the development if your hands is full, just let me know, I will gladly help.. |
@upwebdesign @agmadt - thanks! I'm going to try and finish up the documentation tonight and the push the first version to the development branch. Then you all can jump in and help to polish :) |
With the new major version I'm experimenting with getting the API closer to fluent Laravel way: Create Webinar: $result = Webinar::subject('Some meeting')
->description('Description of the meeting')
->timeFromTo(Carbon::now()->addDays(2)->toW3cString(), Carbon::now()->addDays(2)->addHour()->toW3cString())
->timezone('Europe/Amsterdam')
->singleSession()
->noEmailReminder()
->noEmailConfirmation()
->create(); Update Webinar: $result = Webinar::webinarKey(123456789)
->subject('Some new Subject')
->description('a new description of the meeting')
->update(); Delete Webinar: $result = Webinar::webinarKey(123456789)
->sendCancellationEmails()
->delete(); Create Registrant: $result = Registrant::webinarKey(123456789)
->firstName('Peter')
->lastName('Pan')
->email('[email protected]')
->create(); What do you think of the above API? |
@slakbal this is looking really nice so far. I am inclined to do something like this when creating... Create Registrant: $result = Registrant::webinarKey(123456789)
->create([
'firstName' => 'Peter',
'firstName' => 'Pan',
'email' => '[email protected]'
]); This gives a little more flexibility to add more fields without adding methods. This is just an observation. This is your package and you can decide which way you would like to go. Flags such as: ->sendCancellationEmails() These are really convenient and they explain what is happening very well. I really like this: Create Webinar: $result = Webinar::subject('Some meeting')
->description('Description of the meeting')
->timeFromTo(Carbon::now()->addDays(2)->toW3cString(), Carbon::now()->addDays(2)->addHour()->toW3cString())
->timezone('Europe/Amsterdam')
->singleSession()
->noEmailReminder()
->noEmailConfirmation()
->create(); Alternative suggestion: $result = Webinar::singleSession()
->noEmailReminder()->noEmailConfirmation()
->scheduleFromTo(Carbon::now()->addDays(2)->toW3cString(), Carbon::now()->addDays(2)->addHour()->toW3cString())
->create([
'subject' => 'Some meeting',
'description' => 'Description of the meeting'
'timezone' => 'Europe/Amsterdam'
]); Again, minor, and if the fields for GTW are not named Great work on this. Looking forward to playing around with it. |
@slakbal I just received the final notice from GTW. It is crunch time. Let me know where you are with the updates so we can review. As always, let me know if I can help. Thanks! |
@upwebdesign hey there, I've pushed the newest implementation, will tag only once we are happy with the stability. Will still be adding the sessions, etc. end-points to the implementation asap. Can you in the meantime have a look at it, test and if you find anything let me know, please. |
@upwebdesign hey Jesse, I've also pushed now Attendee and Session operations to the new implementation. Maybe you can test for me something on your side? When adding a registrant I get an API error when I want to delete it bu registranKey, the same also when I want to look up the registrant by registranKey. This also happens on the attendees side of things. I will also follow-up with Goto guys on the ticket I've raised for this. I've marked those issues with //todo in the code. |
@upwebdesign @agmadt @GalBrigitta - Going to close the issue for now since it is getting long. But you help with testing etc. will be appreciated. Especially around the issues on registrantKey. Thanks! |
@slakbal Im very busy at the moment to do new testing with the new code. I was able to use my PR to get oAuth working for now. I will reach out when I think I am ready for the new code. |
100% |
@slakbal I just received this today from GoTo Developer Center:
Do you have any intentions of building out the OAuth 2.0 auth type like you stated in your config file?
The text was updated successfully, but these errors were encountered: