Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Plot Image #89

Merged
merged 6 commits into from
Mar 11, 2025
Merged

Save Plot Image #89

merged 6 commits into from
Mar 11, 2025

Conversation

ngAlexander9
Copy link
Contributor

Adds Save Plot Image button to display.
snip1

Clicking opens a file dialog to allow user to set custom filename and location. Default location is user home.

ang_trace_20250212_161511

SWAPPS-80

@ngAlexander9
Copy link
Contributor Author

Still need to write unit tests for this... might need to ask zdomke tomorrow for assistance.

@ngAlexander9 ngAlexander9 requested a review from a team February 13, 2025 19:55
@ngAlexander9 ngAlexander9 marked this pull request as ready for review February 13, 2025 21:13
Copy link

@shilorigins shilorigins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Locally, the suite passes except for the test fixed by #128 .

As an idea for the future, it could be nice to capture the PV names in the image somehow. Might not be worth the effort if the use case doesn't require it though.

Copy link
Collaborator

@zdomke zdomke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me and all tests pass (except for the test fixed in #128).

@zdomke
Copy link
Collaborator

zdomke commented Mar 11, 2025

Works as advertised. Locally, the suite passes except for the test fixed by #128 .

As an idea for the future, it could be nice to capture the PV names in the image somehow. Might not be worth the effort if the use case doesn't require it though.

zdomke_trace_20250311_093338

It looks like the legend is included in the image if it is enabled

@zdomke zdomke merged commit e1e5b4b into main Mar 11, 2025
1 of 7 checks passed
@zdomke zdomke deleted the ang/save-plot-image branch March 11, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants