Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Fix test_default_curve #128

Merged
merged 1 commit into from
Mar 11, 2025
Merged

TST: Fix test_default_curve #128

merged 1 commit into from
Mar 11, 2025

Conversation

zdomke
Copy link
Collaborator

@zdomke zdomke commented Mar 4, 2025

Fixing a small bug in tests that causes failure.

@zdomke zdomke requested a review from a team March 4, 2025 18:19
@zdomke zdomke added the bug Something isn't working label Mar 4, 2025
@zdomke zdomke added this to the Minimum Viable Product milestone Mar 4, 2025
@zdomke zdomke self-assigned this Mar 4, 2025
shilorigins
shilorigins approved these changes Mar 11, 2025
View reviewed changes
Copy link

@shilorigins shilorigins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally, this fixes the failing test and the suite passes. Not sure about the Windows build in the Actions, but we can save that for another effort.

This was referenced Mar 11, 2025
Merged
Merged
@zdomke zdomke mentioned this pull request Mar 11, 2025
Merged
@zdomke zdomke requested a review from a team March 11, 2025 17:12
@zdomke zdomke merged commit cba3dc0 into main Mar 11, 2025
5 of 7 checks passed
@zdomke zdomke deleted the zdomke/dev_test_fix branch March 11, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilorigins shilorigins shilorigins approved these changes

Assignees

@zdomke zdomke

Labels
bug Something isn't working
Projects
None yet
Milestone
Minimum Viable Product
Development

Successfully merging this pull request may close these issues.
2 participants
@zdomke @shilorigins