`slack-vitess-r14.0.5-dsdefense`: sync changes from `slack-vitess-r14.0.5` by timvaillancourt · Pull Request #121 · slackhq/vitess

timvaillancourt · 2023-08-31T12:00:29Z

Description

This PR syncs the latest changes from slack-vitess-r14.0.5 -> slack-vitess-r14.0.5-dsdefense

Mainly, I'd like to get #119 onto this branch to resolve CI issues

cc @ejortegau

Related Issue(s)

Checklist

"Backport to:" labels have been added if this change should be back-ported
Tests were added or are not required
Did the new or modified tests pass consistently locally and on the CI
Documentation was added or is not required

Deployment Notes

This reverts commit 76159fd.

Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>

* Empty commit to trigger CI Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * `slack-vitess-r14.0.5-dsdefense`: use larger runner Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use runner group instead Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Rename group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Move more jobs to runner group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * use vitess-ubuntu20 runner group Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Rever change of runner type for e2e ERS PRS new features heavy test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Tim Vaillancourt <tim@timvaillancourt.com>

…_heavy. (#116) We do this because the test is taking a lot longer & failing in some cases with the larger runner. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

* `slack-vitess-r14.0.5`: use dedicated larger runner Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix fileNameFromPosition Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * empty commit Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

…error (#117) * Release-15: Cherry pick vtorc no cgo (vitessio#12223) * Move vtorc from go-sqlite3 to modernc.org/sqlite (vitessio#12214) * Move vtorc from go-sqlite3 to modernc.org/sqlite This moves vtorc from the go-sqlite3 library that uses CGO, to use modernc.org/sqlite which is a pure Go implementation. vtorc is the only component we have to build with CGO but it's causing pain for releases since we need to build it against an old Linux for linking against glibc. Using modernc.org/sqlite allows for using Go only again and makes all Vitess components buildable without CGO. In https://datastation.multiprocess.io/blog/2022-05-12-sqlite-in-go-with-and-without-cgo.html someone ran some basic benchmarks. It shows that the pure Go version can be twice as slow, but the usage of vtorc is very limited and we operate on small datasets, so I think the performance impact purely of a somewhat slower sqlite implementation is negligable. None of this is in a hot query serving path or anything like that, so I have little concern performance wise. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix error handling in RowToArray Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * empty-commit Signed-off-by: Manan Gupta <manan@planetscale.com> * Run go mod tidy Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com> * Fix Makefile Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Undo dir rename Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…test + compressors (#119) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code Signed-off-by: Matt Lord <mattalord@gmail.com> * Move used until functions from initialsharding to cluster Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtctl commands Signed-off-by: Matt Lord <mattalord@gmail.com> * Kill vtworker and SetKeyspaceServedFrom cmd Signed-off-by: Matt Lord <mattalord@gmail.com> * WaitForDrain related stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Legacy local straggler workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtworker stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Update throttlerservice protobuf Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove last mentiones of legacy sharding in vtctl Signed-off-by: Matt Lord <mattalord@gmail.com> * remove binlog_use_v3_resharding_mode Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Correct vtgate help output Signed-off-by: Matt Lord <mattalord@gmail.com> * go fmt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * generate vtadmin files Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type from vtadmin Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Merge from main Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Fix bad merge conflict resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix missing 'sharding' import Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * go mod tidy + comments Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add copyright notices Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add support for builtin engine Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing linter errors Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing lint warning Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing test failure Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing un-necessary test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing code review feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing typos in summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing flag name typos Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add 8.0 workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * whitespace Signed-off-by: Matt Lord <mattalord@gmail.com> * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove extraneous changes Signed-off-by: Matt Lord <mattalord@gmail.com> * We need lz4 for TestXtrabackupStreamWithlz4Compression Signed-off-by: Matt Lord <mattalord@gmail.com> * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions Signed-off-by: Matt Lord <mattalord@gmail.com> * Specify stream type everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove repeated server install Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar... Signed-off-by: Matt Lord <mattalord@gmail.com> * Move vtctlbackup test to 8.0 Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename vtbackup test and move to MySQL 8 Signed-off-by: Matt Lord <mattalord@gmail.com> * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. Signed-off-by: Matt Lord <mattalord@gmail.com> * Use MySQL 8 compat method for setting passwords Signed-off-by: Matt Lord <mattalord@gmail.com> * Test increasing timeout at another level Signed-off-by: Matt Lord <mattalord@gmail.com> * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix incorrect password update statement for vt_repl user Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Bump timeouts for 8.0 backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Bump it more :( Signed-off-by: Matt Lord <mattalord@gmail.com> * Increase backup/restore timeout in backup_utils Signed-off-by: Matt Lord <mattalord@gmail.com> * Apply new 8.0 template everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix bugs around how the compression flags were getting passed Signed-off-by: Matt Lord <mattalord@gmail.com> * Use 45m timeout for the workflow, 30m for the run. Signed-off-by: Matt Lord <mattalord@gmail.com> * These changes were no longer needed so limiting diff. Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly skip new linter check Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> * Fix test file merge issues Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Go 1.18.7 to fix error Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix lint Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix vttablet.txt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make web_build to compile production files Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove vars from test Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove sharding column type select box test from web test Signed-off-by: notfelineit <notfelineit@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Arvind Murty <arvind.murty@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arvind Murty <arvind.murty@gmail.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>

…e-branch-slack-vitess-r14.0.5-dsdefense Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

…into update-branch-slack-vitess-r14.0.5-dsdefense Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

github-actions · 2023-10-06T01:25:32Z

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

Push additional commits to the associated branch.
Remove the stale label.
Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

github-actions · 2023-10-13T01:26:38Z

This PR was closed because it has been stale for 7 days with no activity.

Roderick Yao and others added 9 commits July 5, 2023 08:56

Revert "fix parameter name (#93)" (#100)

4f4d47a

This reverts commit 76159fd.

apply patch 12178 to v14 (#102)

82cf45b

Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Signed-off-by: 'Priya Bibra' <pbibra@slack-corp.com>

Merge remote-tracking branch 'origin/slack-vitess-r14.0.5' into updat…

0de3d1b

…e-branch-slack-vitess-r14.0.5-dsdefense Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

timvaillancourt requested a review from a team as a code owner August 31, 2023 12:00

timvaillancourt added 9 commits August 31, 2023 14:09

make embed_config to fix rice-box.go

521e3a8

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

go mod tidy

fd1f9f9

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Merge remote-tracking branch 'origin/slack-vitess-r14.0.5-dsdefense' …

39fe71e

…into update-branch-slack-vitess-r14.0.5-dsdefense Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Fix Makefile

def550c

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Fix vtorc in Makefile

58d48db

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Undelete file

c5df587

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Fix go mod

0d0a45d

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Fix go mod again?

a24434b

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

Fix go mod again. This time with go@1.18

1c7cb12

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

github-actions bot added the Stale label Oct 6, 2023

github-actions bot closed this Oct 13, 2023

timvaillancourt deleted the update-branch-slack-vitess-r14.0.5-dsdefense branch November 22, 2023 02:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`slack-vitess-r14.0.5-dsdefense`: sync changes from `slack-vitess-r14.0.5`#121

`slack-vitess-r14.0.5-dsdefense`: sync changes from `slack-vitess-r14.0.5`#121
timvaillancourt wants to merge 18 commits intoslack-vitess-r14.0.5-dsdefensefrom
update-branch-slack-vitess-r14.0.5-dsdefense

timvaillancourt commented Aug 31, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Oct 6, 2023

Uh oh!

github-actions bot commented Oct 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

timvaillancourt commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Checklist

Deployment Notes

Uh oh!

github-actions bot commented Oct 6, 2023

Uh oh!

github-actions bot commented Oct 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

timvaillancourt commented Aug 31, 2023 •

edited

Loading