-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1276 add Asyncio SQLAlchemy support #1633
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments; Also, it seems the tests fail even for supported Python runtime versions. Could you check the issue?
4be23e7
to
bdcea76
Compare
@seratch will look into that probably today. The problem is that my tests are passing, it just something happens later in tests that they are braking - I think it's somehow related to retrieving asyncio loop by std library. |
bdcea76
to
69822e9
Compare
I've identified the source of the test failures @seratch. The original async_test helper created a single event loop and set it globally, which was the core of the problem. I assume I have to still rework this to make it work with Python 3.6 and 3.7 so in the end I will revert that - but it was nice to find root cause of this. |
I've tested locally now with support from Python 3.6/3.7 Testing with Python 3.7 I got
On my M1 Macbook. |
Summary
Add support for Asyncio SQLAlchemy Installation and StateStore
Testing
Category
/docs
(Documents)/tutorial
(PythOnBoardingBot tutorial)tests
/integration_tests
(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh
after making the changes.