-
Notifications
You must be signed in to change notification settings - Fork 838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Support for EOL Python 3.6, 3.7 and 3.8 #1634
Comments
Hi @galuszkak thanks for writing in! This package is used by Bolt for python therefore our stance on this is similar to the one found in slackapi/bolt-python#603. Dropping support for python versions here means we also need to drop support for them there. Python 3.6 may be getting old, but users still use it with this project. Versions 3.7 and 3.8 also see their fair share of usage. We have not received any explicit security issues that involve this project running on older versions of python. We support these older versions as a convenience to our users.It falls onto individual developers to choose which version of python they should use. Note that, we recommend using the latest version of python in combination with the latest version of this project! |
Hi @WilliamBergamin , Thanks for prompt answer. My main reason for this was that while working on #1633 :
I will try to adjust my PR first - looks like I need to start testing this on lowest Python available. Is it maybe possible to share some analytics/usage data what is actual usage of 3.6/3.7/3.8 versions? Is this more than 5-10% of the downloads or more? |
Thank you for your contribution 🙏 💯
We've developed internal dashboards that collect HTTP request information made to Slacks API by the various python versions, I unfortunately cannot share those. But I did put together this useful script that breaks down the slack_sdk
Display the last 180 days package download statistics
Source: https://pypistats.org/
Version Downloads Percentage
3.6 1764484 1.05%
3.7 9474831 5.64%
3.8 19346104 11.52%
3.9 19927347 11.86%
3.10 48664136 28.97%
3.11 59355900 35.33%
3.12 8967379 5.34%
3.13 496392 0.3%
Total 167996573 n/a All though 1.05% may seem like a small number, due to the scale of total downloads this is still a significant number of users: I've been open to drop support for some of these versions but so fare we have not encountered a significant reason to do this. Would like to get @seratch opinion on this as well |
As @WilliamBergamin mentioned, we maintain support for older versions even though they've been EOLed for some time. Ideally, all real-world applications would quickly migrate to a newer runtime version, but that's not the reality in many cases. We will eventually drop those supports in the long run, but we won't in 2025. Regarding your asyncio SQLAlchemy addition, please adjust your test logic to run the test suite only on compatible runtimes. |
As of today per Python Software Foundation policy here: https://devguide.python.org/versions/
Does Slack SDK plans to remove support for those Python versions? Promoting unsupported version of Python has security concerns and it shouldn't be promoted.
I've realised this while working on #1633 as I wasn't expecting that Python 3.6 is in use and I was using features that were added in Python 3.8 so I lived under assumption that I can use everything from 3.9 and above.
Category
Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
The text was updated successfully, but these errors were encountered: