Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the default OAuth page renderers #1140

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

seratch
Copy link
Member

@seratch seratch commented Apr 13, 2023

This pull request improves the defaut OAuth page renderers not to embed any parameters without HTML escaping. See also: slackapi/bolt-python#882

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:bolt labels Apr 13, 2023
@seratch seratch added this to the 1.29.2 milestone Apr 13, 2023
@seratch seratch self-assigned this Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #1140 (eb1efd7) into main (a288ac8) will increase coverage by 0.08%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##               main    #1140      +/-   ##
============================================
+ Coverage     75.86%   75.95%   +0.08%     
- Complexity     3831     3836       +5     
============================================
  Files           415      415              
  Lines         11902    11907       +5     
  Branches       1181     1182       +1     
============================================
+ Hits           9030     9044      +14     
+ Misses         2163     2155       -8     
+ Partials        709      708       -1     
Impacted Files Coverage Δ
.../default_impl/OAuthDefaultInstallPageRenderer.java 66.66% <50.00%> (+16.66%) ⬆️
...ault_impl/OAuthDefaultRedirectUriPageRenderer.java 66.66% <100.00%> (+31.88%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seratch seratch merged commit 9863d1e into slackapi:main Apr 13, 2023
@seratch seratch deleted the default-oauth-renderer branch April 13, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented project:bolt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant