Improve the default OAuth page renderers not to embed any params without escaping them #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out escaping them
seratch
force-pushed
the
improve-default-renderer
branch
from
b634ba9 to
bc61768
Compare
seratch
commented
Apr 13, 2023
| @@ -58,7 +58,7 @@ | |||
| ), | |||
| include_package_data=True, # MANIFEST.in | |||
| install_requires=[ | |||
| "slack_sdk>=3.20.2,<4", | |||
| "slack_sdk>=3.21.1,<4", | |||
There was a problem hiding this comment.
Set the version to use slackapi/python-slack-sdk#1352 for sure
| @@ -32,7 +33,7 @@ def _build_callback_success_response( # type: ignore | |||
| debug_message = f"Handling an OAuth callback success (request: {request.query})" | |||
| self._logger.debug(debug_message) | |||
|
|
|||
| html = self._redirect_uri_page_renderer.render_success_page( | |||
| page_content = self._redirect_uri_page_renderer.render_success_page( | |||
There was a problem hiding this comment.
Renamed the variable to avoid the name conflict with the module
| @@ -142,4 +142,4 @@ def build_detailed_error(reason: str) -> str: | |||
| elif reason == "storage_error": | |||
| return f"{reason}: The app's server encountered an issue. Contact the app developer." | |||
| else: | |||
| return f"{reason}: This error code is returned from Slack. Refer to the documents for details." | |||
| return f"{html.escape(reason)}: This error code is returned from Slack. Refer to the documents for details." | |||
There was a problem hiding this comment.
for safety of custom renderers by developers
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 181 181
Lines 6285 6285
=======================================
Hits 5766 5766
Misses 519 519
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same way with slackapi/python-slack-sdk#1352 , this pull request improves the default OAuth page renderers to escape any parameters when generating the page content.
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.