Skip to content

Fix a bug in the asyncio based token rotation support #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2021
Merged

Fix a bug in the asyncio based token rotation support #503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
501dfe4
fix perform_token_rotation kwarg
dkzk22 Oct 29, 2021
c7bebce
revoke doc changes
dkzk22 Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/api-docs/slack_bolt/authorization/async_authorize.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ <h1 class="title">Module <code>slack_bolt.authorization.async_authorize</code></
raise BoltError(self._config_error_message)
refreshed = await self.token_rotator.perform_token_rotation(
installation=installation,
token_rotation_expiration_minutes=self.token_rotation_expiration_minutes,
minutes_before_expiration=self.token_rotation_expiration_minutes,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll update the document parts after releasing the next version. Can you revert these changes in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, all done

)
if refreshed is not None:
await self.installation_store.async_save(refreshed)
Expand Down Expand Up @@ -569,7 +569,7 @@ <h3>Ancestors</h3>
raise BoltError(self._config_error_message)
refreshed = await self.token_rotator.perform_token_rotation(
installation=installation,
token_rotation_expiration_minutes=self.token_rotation_expiration_minutes,
minutes_before_expiration=self.token_rotation_expiration_minutes,
)
if refreshed is not None:
await self.installation_store.async_save(refreshed)
Expand Down
2 changes: 1 addition & 1 deletion slack_bolt/authorization/async_authorize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ async def __call__(
raise BoltError(self._config_error_message)
refreshed = await self.token_rotator.perform_token_rotation(
installation=installation,
token_rotation_expiration_minutes=self.token_rotation_expiration_minutes,
minutes_before_expiration=self.token_rotation_expiration_minutes,
)
if refreshed is not None:
await self.installation_store.async_save(refreshed)
Expand Down