Fix a bug in the asyncio based token rotation support #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
seratch
requested changes
Oct 29, 2021
| @@ -237,7 +237,7 @@ <h1 class="title">Module <code>slack_bolt.authorization.async_authorize</code></ | |||
| raise BoltError(self._config_error_message) | |||
| refreshed = await self.token_rotator.perform_token_rotation( | |||
| installation=installation, | |||
| token_rotation_expiration_minutes=self.token_rotation_expiration_minutes, | |||
| minutes_before_expiration=self.token_rotation_expiration_minutes, | |||
There was a problem hiding this comment.
We'll update the document parts after releasing the next version. Can you revert these changes in this file?
Codecov Report
@@ Coverage Diff @@
## main #503 +/- ##
=======================================
Coverage 91.43% 91.43%
=======================================
Files 167 167
Lines 5535 5535
=======================================
Hits 5061 5061
Misses 474 474
Continue to review full report at Codecov.
|
seratch
approved these changes
Oct 29, 2021
|
Thank you very much for fixing this issue 🙇 As this is an obvious bug, your change will be included in the next patch version. |
seratch
changed the title
seratch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kwarg for
perform_token_rotationneeds changing to match the core slack sdkCategory
slack_bolt.async_app.AsyncAppand/or its core componentsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.