Fix/1560 tabs arent correctly marked for screen reader #1637
Conversation
…orrectly-marked-for-screen-reader
…nning (partially working)
🦋 Changeset detectedLatest commit: afeb6ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🕸 Website previewYou can view a preview here (commit |
🕸 Storybook previewYou can view a preview here (commit |
…orrectly-marked-for-screen-reader
| @@ -27,6 +27,11 @@ declare global { | |||
| */ | |||
| @localized() | |||
| export class MenuButton extends ScopedElementsMixin(LitElement) { | |||
| /** @internal */ | |||
| static override get observedAttributes(): string[] { | |||
| return [...super.observedAttributes, 'aria-disabled', 'aria-label']; | |||
There was a problem hiding this comment.
This is awesome, but i'm left wondering if we couldn't make a mixin that does this? I'm entirely not sure you can change static things from a mixin, but it would be wort the investigation? .... I think you can; see this RFC and the FormAssociatedMixin lit/rfcs#43
There was a problem hiding this comment.
Those observed attributes can differ per component, so I left setting them in the components, but I've created a mixin that makes the rest.
No description provided.