Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/package-lock #166

Merged
merged 3 commits into from
Mar 24, 2022
Merged

feature/package-lock #166

merged 3 commits into from
Mar 24, 2022

Conversation

jbraese
Copy link
Collaborator

@jbraese jbraese commented Mar 9, 2022

closes #158

The file was generated with the following versions: node 16.14.0, npm 8.3.1, and Angular CLI 13.2.5.

@jbraese
Copy link
Collaborator Author

jbraese commented Mar 14, 2022

I just noticed that when we run automated builds as part of our tests, we don't actually seem to use package-lock.json (see here and here). Does someone know, why we don't use it there? It might prevent us from catching similar issues in the future.

@jbraese jbraese marked this pull request as draft March 16, 2022 08:59
@jbraese jbraese marked this pull request as ready for review March 16, 2022 16:14
@felixerdy felixerdy mentioned this pull request Mar 21, 2022
Closed
@felixerdy felixerdy self-requested a review March 24, 2022 09:49
@felixerdy felixerdy merged commit 8e18dec into develop Mar 24, 2022
@felixerdy felixerdy deleted the feature/package-lock branch March 24, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixerdy felixerdy felixerdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm integrity check background-geo-location
2 participants
@jbraese @felixerdy