Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and build execution: use npm ci #169

Closed
zven opened this issue Mar 16, 2022 · 1 comment · Fixed by #177
Closed

Test and build execution: use npm ci #169

zven opened this issue Mar 16, 2022 · 1 comment · Fixed by #177
Assignees

Comments

@zven
Copy link
Contributor

zven commented Mar 16, 2022

@jbraese realized, while working on #158, that we are using npm install for our automated build, test and deployment processes. To execute those with a clean install, it's advised to usenpm ci instead: https://docs.npmjs.com/cli/v8/commands/npm-ci

@felixerdy
Copy link
Collaborator

I think we should first investigate #166 (comment) in #166 as npm config set package-lock false installs different versions of packages (which you can see in the /src/assets/licenses.json file generated in the postinstall script). Other than that npm ci works fine for me and also triggers the postinstall script which is nice.

@felixerdy felixerdy self-assigned this Mar 24, 2022
felixerdy added a commit that referenced this issue Mar 24, 2022
@felixerdy felixerdy mentioned this issue Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants