Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check and fix various inconsistencies #47

Closed
Studio384 opened this issue Oct 10, 2022 · 0 comments
Closed

Check and fix various inconsistencies #47

Studio384 opened this issue Oct 10, 2022 · 0 comments
Assignees
Labels
design Issues related to icon design
Milestone

Comments

@Studio384
Copy link
Collaborator

Studio384 commented Oct 10, 2022

While designing Valkyrie, the way icons were drawn has been highly inconsistent. Recent icons started using the round line cap as it should, but various icons don't use it. Our roundings are also highly inconsistent due to random usage of inner, centered and outer borders.

This issue is about reworking icons to match the following guidelines:

  • The stroke alignment MUST be set to centered.
  • The cap style MUST be set to rounded.
  • The join style MUST be set to round.

In part this should greatly reduce the post-flattened changes that we have to make to icons.

@Studio384 Studio384 added the design Issues related to icon design label Oct 10, 2022
@Studio384 Studio384 added this to the Version 1.0 milestone Oct 10, 2022
@Studio384 Studio384 self-assigned this Oct 10, 2022
Studio384 added a commit that referenced this issue Oct 10, 2022
Includes examples of new modifiers #43, updated grid #45, use of non-zero rule #46, and various fixes #47
@Studio384 Studio384 mentioned this issue Oct 10, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues related to icon design
Projects
None yet
Development

No branches or pull requests

1 participant