-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sass #3
Added sass #3
Conversation
…k which was correct but I was not expecting that on the test
Thanks for the pull request. This is fantastic! @kennethormandy is testing this PR and making some tweaks to the error reporting. |
@kennethormandy If you have a moment could you gather what information you can on the libsass binaries? What are all the pre-built binaries available to us? How much size would it add to harp if we just shipped the binaries directly? If you can gather that info for me, I'll look into how we ship and use the pre-built binaries directly rather than requiring the build step. |
Node-sass comes with the following binaries pre-built: Right now, OS X rebuilds each time instead of using the included binary: sass/node-sass#140. This new pull request on Node-sass looks like just what we were hoping for: it checks if the binary is included, and only builds it if it’s necessary. I’ve re-added the binaries to it and am trying it out. |
+1 - really want this supported, especially seeing this tweet - https://twitter.com/damln/status/390470984522010625 |
@phated Wow, thanks, that hopefully helps me with sintaxi/harp#113. |
This was merged in and taken care of a while ago:
|
Added node-sass to be able to use sass