Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sass #3

Closed
wants to merge 4 commits into from
Closed

Conversation

carlosrodriguez
Copy link
Contributor

Added node-sass to be able to use sass

@sintaxi
Copy link
Owner

sintaxi commented Aug 30, 2013

Thanks for the pull request. This is fantastic!

@kennethormandy is testing this PR and making some tweaks to the error reporting.

@sintaxi
Copy link
Owner

sintaxi commented Aug 30, 2013

@kennethormandy If you have a moment could you gather what information you can on the libsass binaries? What are all the pre-built binaries available to us? How much size would it add to harp if we just shipped the binaries directly? If you can gather that info for me, I'll look into how we ship and use the pre-built binaries directly rather than requiring the build step.

@kennethormandy
Copy link
Collaborator

Node-sass comes with the following binaries pre-built: darwin-x64, linux-arm, linux-ia32, linux-x64, sunos-x64, win32-ia32, win32-x64. The pre-built binaries are about ~4.5MB, Node-sass is ~50MB—but since the pre-built binaries are already included, I don’t think the size is as much of an issue as we thought it would be.

Right now, OS X rebuilds each time instead of using the included binary: sass/node-sass#140.

This new pull request on Node-sass looks like just what we were hoping for: it checks if the binary is included, and only builds it if it’s necessary. I’ve re-added the binaries to it and am trying it out.

@phated
Copy link

phated commented Oct 17, 2013

+1 - really want this supported, especially seeing this tweet - https://twitter.com/damln/status/390470984522010625

@kennethormandy
Copy link
Collaborator

@phated Wow, thanks, that hopefully helps me with sintaxi/harp#113.

@kennethormandy
Copy link
Collaborator

This was merged in and taken care of a while ago:

We’re happy to announce the latest version of Harp supports Sass via the SCSS syntax! You can read the full details in the Harp v0.11.0 blog post. To get started right away, upgrade or instal Harp with sudo npm -g install harp (omit sudo if you’re using Windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants