-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sass #71
Comments
Do we want Sass or the new SCSS or does it really matter? |
Personally I would go for scss, but there's also many who prefer the sass syntax. |
Based on #54 (comment), conceptually I think we’d like to support both. CSS would have two whitespace sensitive pre-processors (Sass and Stylus) and two superset pre-processors (LESS and SCSS). That said, it looks like hcatlin/libsass supports only SCSS. 😿 If we’re only going to have one, it should definitely be SCSS, but I’d like to see both in Harp if possible. Edit |
Any idea when/if this will make it into Harp? I agree with all the comments above, but my vote is for SASS. |
Hey @SimonWade, I’ve been testing SCSS support and I’d say it’s going well. Harp needs to stays as easy to install as it is now; this is where the current effort is going. The discussion is here: sintaxi/terraform#3 Not supporting the indented syntax was briefly discussed since we thought it might be dropped, but I’ve since found this:
—Adam Stacoviak, Sass’s indented syntax has not been and will never be deprecated!
—Nathan Weizenbaum, The Indented Sass Syntax is Here to Stay So I’m not where that’s been coming from. In any case, it will definitely be the most inconvenient to implement, but I do have a couple of ideas. Requiring the Gem has been ruled out since Harp should just take care of it. I would love to see node-sass-indented working. If you have any comments on either matter, we’d love feedback or help here. |
👍 for Sass support. Don't see why supporting |
@danawoodman yep, it's in the works. |
👍 for this. |
Would it be possible to add support for compass plugins/configuration as well? |
@Apathetic012 Great question, it’s definitely something we’re trying to be on top of. More details in #113. |
Casting my vote for the .sass flavor. |
I also prefer the SASS flavour, but it's only supported by the Ruby implementation (not libsass) and it's too slow. I'm happy to use SCSS if it means I get the speed of libsass, also it makes it easy to copy and paste from Dev Tools. |
Yeah. I'm both a Rails guy and a Node guy, so I think I'll just have to embrace both syntaxes. I was feeling inspired, so I rewrote my mixin library in Stylus after posting my original comment: https://github.com/dw2/mix-master |
Yeah, if you like the .sass syntax then Stylus is a good option. |
My vote would be for SCSS syntax. Not rushing at all, but is there an idea of when Sass support will land in Harp? |
@SimonWade @dw2 @commadelimited SCSS syntax should be in Harp when this issue is closed: sass/node-sass#148 The indented syntax will be the easiest to add if this issue is taken care of: sass/libsass#16 |
Thanks Kenneth. I'm planning on submitting a Harp based topic to a few 2014 conferences including jQCon in San Diego. I just heard about it for the first time this week, but it sounds awesome. |
@commadelimited here it is plain and simple. When |
@sintaxi, that's a plain enough response. Thanks. Looking forward to hearing the good news. :D |
looks like sass/node-sass#148 closed a few days after the last comments, so is this unblocked? |
Casting my vote for the .sass flavor. |
I'd be super happy with support for |
@sintaxi it seems like the mocha dependency is used to verify that the binary works at install time. Is that a blocker? I'm keen to try this out. Are there any changes needed on the Harp side or is it all Terraform? |
@edrex I think we can live with the mocha dependancy for now. The code is mostly in Terraform with a small change in harp to expose the extension. |
Seems to work with Harp master, I think the change went in as 66ca961. |
+1 here, the only thing stopping me from entirely loving HarpJS is the lack of SASS support. |
Hey everyone, We’re happy to announce the latest version of Harp supports Sass via the SCSS syntax! You can read the full details in the Harp v0.11.0 blog post. To get started right away, upgrade or instal Harp with Many of you were also interested in using the |
Great news Kenneth! Looking forward to .sass syntax :) T On 30 December 2013 22:41, Kenneth Ormandy [email protected] wrote:
|
Since there is now a C based Sass compiler (https://github.com/hcatlin/libsass), with a wrapper based in node (https://github.com/andrew/node-sass) Im guessing this could possibly be done.
The text was updated successfully, but these errors were encountered: