Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Quill Doesn't Work On iOS 16 or Xcode 14 Betas (Stored properties cannot be marked potentially unavailable with '@available') #883

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

garv-shah
Copy link
Contributor

As documented in this issue here (pichillilorenzo/flutter_inappwebview#1251), one of Flutter Quill's dependencies, Flutter In App Webview, causes the following issue on the new apple betas:

Could not build the precompiled application for the device.
Swift Compiler Error (Xcode): Stored properties cannot be marked potentially unavailable with '@available'
/Users/garv/development/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_inappwebview-5.4.3+7/ios/Classes/Types/UserScript.swift:12:5

Uncategorized (Xcode): Command SwiftCompile failed with a nonzero exit code

As such, the following PR to Flutter In App Webview could be used to circumvent the issue: pichillilorenzo/flutter_inappwebview#1238

The problem is, for Flutter Quill, this is a dependency of a dependency, going Flutter Quill -> YouTube Player Flutter -> Flutter In App Webview, and YouTube Player Flutter doesn't seem very frequently updated, so it may be quite a few months before this is fixed.

As such, this PR changes the dependency to a fork of these repos, to fix the above issue :D

@singerdmx singerdmx merged commit 6647b53 into singerdmx:master Jul 24, 2022
@singerdmx
Copy link
Owner

Thanks for the fix

@garv-shah
Copy link
Contributor Author

garv-shah commented Jul 24, 2022

Thank you ! :)

@singerdmx
Copy link
Owner

singerdmx commented Jul 24, 2022

This seems to prevent publishing:

Package validation found the following potential issue:

  • Don't depend on "youtube_player_flutter" from the git source. Use the hosted source instead. For example:

    dependencies:
    youtube_player_flutter: ^8.1.0

    Using the hosted source ensures that everyone can download your package's dependencies along with your package.

Publishing is forever; packages cannot be unpublished.
Policy details are available at https://pub.dev/policy

Package has 1 warning.. Do you want to publish flutter_quill 5.2.3 (y/N)? y
Uploading...
Package dependency youtube_player_flutter is a git dependency, this is not allowed in published packages.

@singerdmx
Copy link
Owner

@garv-shah do you have workaround? Maybe fork YouTube Player Flutter and create a pub package?

@singerdmx
Copy link
Owner

Is it possible for you to publish your fork of https://github.com/garv-shah/youtube_player_flutter as pub package?
Otherwise we won't be able to publish new version of flutter quill anymore

@garv-shah
Copy link
Contributor Author

Yeah, I just searched it up, that seems to be the case. I'll attempt to create them all as pub packages and see if that works, hopefully it does

@singerdmx
Copy link
Owner

Thanks so much! Appreciate it

@garv-shah
Copy link
Contributor Author

Nice, it seems to work, I created another PR here: #884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants