Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed Xcode 14 build error #1238

Merged
merged 2 commits into from
Oct 3, 2022
Merged

fix: fixed Xcode 14 build error #1238

merged 2 commits into from
Oct 3, 2022

Conversation

CodeEagle
Copy link
Contributor

@CodeEagle CodeEagle commented Jun 29, 2022

Connection with issue(s)

Resolve issue #1216

Connected to #1216

Testing and Review Notes

Screenshots or Videos

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@CodeEagle CodeEagle changed the title change: fixed Xcode 14 build error fix: fixed Xcode 14 build error Jun 29, 2022
Copy link

@mikhael28 mikhael28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm personally that this merge fixes this issue: #1216

@mikhael28
Copy link

@pichillilorenzo would you please review and merge this in? Right now, in the XCode beta, I have to manually edit the package file.

@MrJohnDev
Copy link

Merge it, Works on XCode 14 Beta 4

@@ -10,8 +10,19 @@ import WebKit

public class UserScript : WKUserScript {
var groupName: String?

var contentWorldWrapper: Any?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to make this variable private bacause it's a detail of implementation

lazy var contentWorld: WKContentWorld = WKContentWorld.page
var contentWorld: WKContentWorld {
get {
if let value = contentWorldWrapper as? WKContentWorld {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep lazy behaviour i'd suggest the following implementation

if contentWorldWrapper == nil {
    contentWorldWrapper = WKContentWorld.page
}
return contentWorldWrapper as! WKContentWorld

, but yours is safer

@sujithv28
Copy link

When will this be merged?

@Attiv
Copy link

Attiv commented Sep 13, 2022

When will this be merged?

1 similar comment
@cimplesid
Copy link

When will this be merged?

@cimplesid
Copy link

cimplesid commented Sep 13, 2022

Until it is merged you can use

flutter_inappwebview:
    git: https://github.com/CodeEagle/flutter_inappwebview

and then run the following command

flutter pub get && cd ios && pod install

@huylethanh
Copy link

Please merge it

@mikhael28
Copy link

@cimplesid boss

@j-ixcayau
Copy link

Please merge it, it works for me too

@acn-masatadakurihara
Copy link

@pichillilorenzo Please merge it

@calmog
Copy link

calmog commented Sep 15, 2022

Anyone finding themselves with a conflict between the git dependency and a transitive dependency on the hosted flutter_inappwebview, can use this code in their pubspec.yaml:

dependency_overrides:
  flutter_inappwebview:
    git:
      url: https://github.com/CodeEagle/flutter_inappwebview

@EricksonMoura45
Copy link

Anyone finding themselves with a conflict between the git dependency and a transitive dependency on the hosted flutter_inappwebview, can use this code in their pubspec.yaml:

dependency_overrides:
  flutter_inappwebview:
    git:
      url: https://github.com/CodeEagle/flutter_inappwebview

Thanks, Buddy :)

@emrementese
Copy link

Anyone finding themselves with a conflict between the git dependency and a transitive dependency on the hosted flutter_inappwebview, can use this code in their pubspec.yaml:

dependency_overrides:
  flutter_inappwebview:
    git:
      url: https://github.com/CodeEagle/flutter_inappwebview

Thank you. İts workly !

@calmog
Copy link

calmog commented Sep 18, 2022

Any ETA as to when will this fix be merged? RN I need to add the dependency override to allow a build on iOS, but it breaks the build on Android, so I have to constantly go back and forth with adding/removing it.

@sowmitri123
Copy link

sowmitri123 commented Sep 19, 2022

What is the ETA on when this fix be merged?? Currently i am not able build the app for iOS without this fix.

@n13
Copy link

n13 commented Sep 20, 2022

Another workaround: Set deployment target for pods and project to iOS 14.

May or may not be a good workaround for you, just dropping it here.

It's a good one for me, because I need WASM support from inapp_webview, and on iOS the earliest version of iOS that supports WASM in JavaScriptCore is iOS 14. So now I have 2 reasons to require 14 as the minimum version. Previously the app would show an error dialog asking users to upgrade, now it just won't run at all on 13 and below.

@charlieforward9
Copy link

Please merge this. I would appreciate not implementing in a workaround when the solution exists!

@Yokoi-K
Copy link

Yokoi-K commented Sep 21, 2022

@pichillilorenzo

This PR fix solved it for us too.
Please MERGE as soon as possible.🙏🙇‍♂️

@duy-mai-otsv
Copy link

Merge, please.....

@anggrayudi
Copy link

This is a blocker and should be fixed ASAP.

@ethanzhrepo
Copy link

Until it is merged you can use

flutter_inappwebview:
    git: https://github.com/CodeEagle/flutter_inappwebview

and then run the following command

flutter pub get && cd ios && pod install

It works

@DavidGrunheidt
Copy link

Also blocked a release for my app. Please merge it

@MagneticRegulus
Copy link

This is also a blocker for an app release for me. We have a small user base, and we are required to support older versions of iOS. Please merge.

Note, we are dependent on this because we use youtube_player_flutter.

@10ndavis
Copy link

@pichillilorenzo let's get this merged!

@lowapple
Copy link

Plz merge it!

@trumdongnat
Copy link

Please merge it.

@pichillilorenzo pichillilorenzo merged commit 252d836 into pichillilorenzo:master Oct 3, 2022
@pichillilorenzo
Copy link
Owner

Released new version 5.4.3+8, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.