Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add globby.stream #113

Merged
merged 12 commits into from
Jun 15, 2019
Merged

Add globby.stream #113

merged 12 commits into from
Jun 15, 2019

Conversation

futpib
Copy link
Contributor

@futpib futpib commented Mar 16, 2019

Fixes #83

This adds support for async iteration by adding globby.stream which returns a ReadableStream.

Node 10 introduced experimental async iterator support to ReadableStream so if supported by one's node version, one can use globby.stream in a for-await-of loop as witnessed by this test https://github.com/futpib/globby/blob/958e81505b1baa7d73e29dbe3468123032cce9cf/test.js#L85-L92

index.js Show resolved Hide resolved
@futpib futpib force-pushed the async-iteration branch from 958e815 to 6b8c1ff Compare April 6, 2019 10:29
@sindresorhus
Copy link
Owner

test.js Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
stream-utils.js Show resolved Hide resolved
@sindresorhus
Copy link
Owner

Can you fix the merge conflicts?

@futpib futpib force-pushed the async-iteration branch from 6b8c1ff to d740c76 Compare June 14, 2019 20:34
@futpib futpib force-pushed the async-iteration branch from e211cdd to 69940a0 Compare June 14, 2019 20:59
@futpib
Copy link
Contributor Author

futpib commented Jun 14, 2019

I have addressed all the review comments 👌

@sindresorhus sindresorhus merged commit 8aadde8 into sindresorhus:master Jun 15, 2019
@sindresorhus
Copy link
Owner

Thanks 🙌

You need to submit the PR URL here to claim the bounty: https://issuehunt.io/r/sindresorhus/globby/issues/83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async-iteration support
3 participants