Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async-iteration support #83

Closed
rektide opened this issue May 6, 2018 · 11 comments · Fixed by #113
Closed

Async-iteration support #83

rektide opened this issue May 6, 2018 · 11 comments · Fixed by #113
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@rektide
Copy link

rektide commented May 6, 2018

Issuehunt badges

It would be great to see results as they are found. By implementing JavaScript async iteration support, we could be able to have results stream in as they are located.

Filing as a feature request here, because this is my favorite glob library. 🤩 Thanks!!!


IssueHunt Summary

futpib futpib has been rewarded.

Backers (Total: $80.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@sindresorhus
Copy link
Owner

Would be useful, yes. Can you open an issue on https://github.com/mrmlnc/fast-glob too? As it will have to be implemented there first.

@sindresorhus sindresorhus changed the title async-iteration support Async-iteration support May 6, 2018
@mysticatea
Copy link

mysticatea commented Jun 26, 2018

It looks to exist in fast-glob: fg.stream(patterns, [options])
(though it's experimental in Node 10...)

@IssueHuntBot
Copy link

@issuehuntfest has funded $80.00 to this issue. See it on IssueHunt

@rijnhard
Copy link

I have code that already does this (converts a stream to an async iterator) based on fast-glob, the only issue is that I'm quite worried about compatibility since I was abusing babel to get it working.

@mrmlnc
Copy link
Contributor

mrmlnc commented Jan 15, 2019

JFYI: Here you need to understand that now there is no way to open the directory for reading in the stream. Now we first read the directory and then send its entries to the stream. So now Async-Iterator will be just sugar for Stream API.

@rijnhard
Copy link

@mrmlnc Correct, afaik this is required libuv/libuv#2057
But even so its simplifies usage, which is fine for now.

@elyager
Copy link

elyager commented Feb 12, 2019

@rijnhard @mrmlnc is any of you working on this issue?, is still worth to get it implemented? even if is just a sugar syntax for Stream API.

@rijnhard
Copy link

@elyager I'm willing to make the PR, but I haven't because it requires babel hackery and I'm not sure how it will operate on older JS versions.

If I can get a concrete answer on going ahead with it anyway (regardless of babel usage, even if only for review purposes) then I'll make the PR. But I know if it was my library this would be an issue.

tl;dr

  1. does the babel requirement disqualify it?
  2. should I make the PR anyway for review?

@elyager
Copy link

elyager commented Feb 12, 2019

@rijnhard you right, I hope you get the answer you need soon.

@sindresorhus
Copy link
Owner

  1. does the babel requirement disqualify it?

Yes, I'm not interested in using Babel here.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@issuehunt-oss issuehunt-oss bot removed the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jul 2, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 2, 2019

@sindresorhus has rewarded $72.00 to @futpib. See it on IssueHunt

  • 💰 Total deposit: $80.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $8.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants