-
-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Friday Night Funkin' Resources #2503
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
I DIDN'T MADE IT, @FunkinCrew MADE THIS LIST AAAAAAAAAAAAAAAAAA! nobody submitted it so i should do it |
unicorn |
Hi @lime360 I think your PR misses some love:
As for the list itself, it needs some adjustments too.
Even though you're not the author of the list, I'm sure you can contribute to make the list comply with the requirements. |
@lime360 I understood that someone else created that list. To support Sindre a bit, I comment on this issue. As Sindre noted above, for a list to be included in the awesome-list, that list should fulfill various requirements. When looking at the repo, many things from the guidelines are still to be improved / changed. @FunkinCrew must change some of the project settings (setting topics, change repo name) and the list itself must be improved according to the guidelines. Hope you keep working on the list that it gets merged. For new lists there is also #2242 which would be the place for such a list in "draft" mode for the future. |
Hello sir,iam a learner i need to know how can i operate termux in an android,please! |
@Superlegend717 i am sorry but this is off-topic. |
Ok,thank you so much for respond. |
i edited my first pr message |
Hey, I am a maintainer for the Friday Night Funkin' Resources repository. I will be looking through this thread and attempting to fix the issues I can. Feel free to @ me if you have any other concerns. |
@@ -547,6 +547,7 @@ | |||
- [Minecraft](https://github.com/bs-community/awesome-minecraft#readme) - Sandbox video game. | |||
- [Game Datasets](https://github.com/leomaurodesenv/game-datasets#readme) - Materials and datasets for Artificial Intelligence in games. | |||
- [Haxe Game Development](https://github.com/Dvergar/awesome-haxe-gamedev#readme) - A high-level strongly typed programming language used to produce cross-platform native code. | |||
- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources#readme) - A rhythm game made in HaxeFlixel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this line to read the following:
- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources) - A cartoon rhythm game made for Newgrounds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that looks better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the guidelines, the #readme is required which is also more user friendly to directly jump to it when opening the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so the correct description should be:
- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources#readme) - A cartoon rhythm game made for Newgrounds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The URL is incorrect
As of time of writing, the only pending issue I am aware of on the Funkin' Resources repository is the age one. All other linting issues have been resolved. Please feel free to provide any additional feedback or PRs if necessary. |
Nice improvements since last time I looked over it 2 weeks ago. The repo name as required by the guidelines needs an "awesome-..." prefix.
|
Ah, I misunderstood this, I interpreted that statement as "the repo must be in lower kebab case" and not "the repo must be in lower kebab case and start with I will look into getting it changed. |
At time of writing, ALL KNOWN ISSUES ARE CURRENTLY FIXED, including the one regarding repo age. The repository now passes all linting checks. |
The workflow will need to be re-run in order for GitHub to validate the changes. |
@@ -547,6 +547,7 @@ | |||
- [Minecraft](https://github.com/bs-community/awesome-minecraft#readme) - Sandbox video game. | |||
- [Game Datasets](https://github.com/leomaurodesenv/game-datasets#readme) - Materials and datasets for Artificial Intelligence in games. | |||
- [Haxe Game Development](https://github.com/Dvergar/awesome-haxe-gamedev#readme) - A high-level strongly typed programming language used to produce cross-platform native code. | |||
- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources#readme) - A rhythm game made in HaxeFlixel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so the correct description should be:
- [Friday Night Funkin'](https://github.com/FunkinCrew/funkin-resources#readme) - A cartoon rhythm game made for Newgrounds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may make sense to use Instead use #2242 for further definition of this list. |
Incorrect. This list is only pending the resolution of minor fixes before being reapproved for submission. |
The readme header should be |
add this list
this list is all about fnf and i was wondering if i can put it here lol
this list is made by @FunkinCrew (fnf developers), not me
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.