-
-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZeroNet #2327
Add ZeroNet #2327
Conversation
Thanks for making an Awesome list! 🙌 It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome. |
Also:
|
At the top of PR you describe the list, but you should describe ZeroNet
|
Hi @zolagonano, Here are some of the formatting stuff I noticed with your list.
I noticed you are using markdown tables for your list entries. I understand why you formatted it this way but it might cause a ton of errors when using the linter. Hope that helps. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've also got the following lint warnings
If it helps, you can run npx awesome-lint
within your project to work through any errors locally.
Thanks for the feedback @bytecauldron / @Lissy93 i will fix those soon :) |
Fixed the lint errors, thanks |
@bytecauldron thanks for the help, fixed those issues that you mentioned :) |
There are some unmaintained sites in the list, but i have included a note for them. |
unicorn |
@zolagonano |
@sindresorhus unicorn |
Great Idea 💡 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Status check still failing.
I opened a PR on your repo to add in CI that you can use to verify it will pass (same thing this repo uses)
@zrosenbauer Thanks, merged it |
The use of tables for everything makes the list very messy and hard to navigate. |
@sindresorhus Thanks, fixed those typos, but currently I don't have a replacement for tables |
I also don't see the point of the "Active Maintenance" column. If it's not maintained, it's not awesome, and should not be included in the list. If you really want it included, it should be a separate Markdown file. |
If you insist on keeping the tables (which I would strongly recommend moving away from), at least make the "description" come after the "name". |
Thanks, removed "Active Maintenance" column and moved unmaintained projects to another markdown file, Also moved "Description" column next to name column. |
https://github.com/zolagonano/awesome-zeronet#readme
ZeroNet is a distributed web-like peer-to-peer network, this list is going to help new users to find the sites, tools, implementations, plugins, and guides on ZeroNet
Reviewed PRs:
New reviewed PRs:
By submitting this pull request I confirm I've read and complied with the below requirements 🖖
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
Requirements for your pull request
Try to prioritize unreviewed PRs, but you can also add more comments to reviewed PRs. Go through the below list when reviewing. This requirement is meant to help make the Awesome project self-sustaining. Comment here which PRs you reviewed. You're expected to put a good effort into this and to be thorough. Look at previous PR reviews for inspiration. Just commenting “looks good” or simply marking the pull request as approved does not count! You have to actually point out mistakes or improvement suggestions.
Add Name of List
.Add Swift
Add Software Architecture
Update readme.md
Add Awesome Swift
Add swift
add Swift
Adding Swift
Added Swift
- [iOS](…) - Mobile operating system for Apple phones and tablets.
- [Framer](…) - Prototyping interactive UI designs.
- [iOS](…) - Resources and tools for iOS development.
- [Framer](…)
- [Framer](…) - prototyping interactive UI designs
#readme
.- [Software Architecture](https://github.com/simskij/awesome-software-architecture#readme) - The discipline of designing and building software.
Requirements for your Awesome list
That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-lint
on your list and fix the reported issues. If there are false-positives or things that cannot/shouldn't be fixed, please report it.main
, notmaster
.Mobile operating system for Apple phones and tablets.
Prototyping interactive UI designs.
Resources and tools for iOS development.
Awesome Framer packages and tools.
If you have not put in considerable effort into your list, your pull request will be immediately closed.
awesome-name-of-list
.awesome-swift
awesome-web-typography
awesome-Swift
AwesomeWebTypography
# Awesome Name of List
.# Awesome Swift
# Awesome Web Typography
# awesome-swift
# AwesomeSwift
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.Contributing
orFootnotes
sections.https://github.com/<user>/<repo>/community/license/new?branch=main&template=cc0-1.0
(replace<user>
and<repo>
accordingly).license
orLICENSE
in the repo root with the license text.Licence
section to the readme. GitHub already shows the license name and link to the full text at the top of the repo.unicorn
.contributing.md
. Casing is up to you.Contributing
, positioned at the top or bottom of the main content.Footnotes
section at the bottom of the readme. The section should not be present in the Table of Contents.Example:
- [AVA](…) - JavaScript test runner.
Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.
Inspired by awesome-foo
orInspired by the Awesome project
kinda link at the top of the readme. The Awesome badge is enough.Go to the top and read it again.