Skip to content

Commit

Permalink
fix(core): Fix user-management:reset command (n8n-io#3403)
Browse files Browse the repository at this point in the history
* 🐛 Fix `email` setting

* 🧪 Add test

* 🧪 Add expectation for user email

* ⚡ Replace request with helper
  • Loading branch information
ivov authored and simshaun committed Jun 4, 2022
1 parent 13e3089 commit 9b314a1
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/cli/src/databases/entities/User.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ export class User {
@BeforeInsert()
@BeforeUpdate()
preUpsertHook(): void {
this.email = this.email?.toLowerCase();
this.email = this.email?.toLowerCase() ?? null;
this.updatedAt = new Date();
}

Expand Down
44 changes: 44 additions & 0 deletions packages/cli/test/integration/commands/reset.cmd.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { execSync } from 'child_process';

import express from 'express';
import path from 'path';

import { Db } from '../../../src';
import * as utils from '../shared/utils';
import type { Role } from '../../../src/databases/entities/Role';
import * as testDb from '../shared/testDb';
import { randomEmail, randomName, randomValidPassword } from '../shared/random';

let app: express.Application;
let testDbName = '';
let globalOwnerRole: Role;

beforeAll(async () => {
app = utils.initTestServer({ endpointGroups: ['owner'], applyAuth: true });
const initResult = await testDb.init();
testDbName = initResult.testDbName;

globalOwnerRole = await testDb.getGlobalOwnerRole();
});

afterAll(async () => {
await testDb.terminate(testDbName);
});

test('user-management:reset should reset DB to default user state', async () => {
await testDb.createUser({ globalRole: globalOwnerRole });

const command = [path.join('bin', 'n8n'), 'user-management:reset'].join(' ');

execSync(command);

const user = await Db.collections.User.findOne();

expect(user?.email).toBeNull();
expect(user?.firstName).toBeNull();
expect(user?.lastName).toBeNull();
expect(user?.password).toBeNull();
expect(user?.resetPasswordToken).toBeNull();
expect(user?.resetPasswordTokenExpiration).toBeNull();
expect(user?.personalizationAnswers).toBeNull();
});

0 comments on commit 9b314a1

Please sign in to comment.