Skip to content

Commit

Permalink
refactor(editor): Change node-setting's parameters order (n8n-io#3435)
Browse files Browse the repository at this point in the history
  • Loading branch information
RicardoE105 authored and simshaun committed Jun 4, 2022
1 parent 059f99a commit 13e3089
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 20 deletions.
38 changes: 19 additions & 19 deletions packages/editor-ui/src/components/NodeSettings.vue
Original file line number Diff line number Diff line change
Expand Up @@ -198,25 +198,6 @@ export default mixins(
} as INodeParameters,
nodeSettings: [
{
displayName: this.$locale.baseText('nodeSettings.notes.displayName'),
name: 'notes',
type: 'string',
typeOptions: {
rows: 5,
},
default: '',
noDataExpression: true,
description: this.$locale.baseText('nodeSettings.notes.description'),
},
{
displayName: this.$locale.baseText('nodeSettings.notesInFlow.displayName'),
name: 'notesInFlow',
type: 'boolean',
default: false,
noDataExpression: true,
description: this.$locale.baseText('nodeSettings.notesInFlow.description'),
},
{
displayName: this.$locale.baseText('nodeSettings.alwaysOutputData.displayName'),
name: 'alwaysOutputData',
Expand Down Expand Up @@ -287,6 +268,25 @@ export default mixins(
noDataExpression: true,
description: this.$locale.baseText('nodeSettings.continueOnFail.description'),
},
{
displayName: this.$locale.baseText('nodeSettings.notes.displayName'),
name: 'notes',
type: 'string',
typeOptions: {
rows: 5,
},
default: '',
noDataExpression: true,
description: this.$locale.baseText('nodeSettings.notes.description'),
},
{
displayName: this.$locale.baseText('nodeSettings.notesInFlow.displayName'),
name: 'notesInFlow',
type: 'boolean',
default: false,
noDataExpression: true,
description: this.$locale.baseText('nodeSettings.notesInFlow.description'),
},
] as INodeProperties[],
};
Expand Down
2 changes: 1 addition & 1 deletion packages/editor-ui/src/plugins/i18n/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@
"nodeSettings.notes.description": "Optional note to save with the node",
"nodeSettings.notes.displayName": "Notes",
"nodeSettings.notesInFlow.description": "If active, the note above will display in the flow as a subtitle",
"nodeSettings.notesInFlow.displayName": "Display note in flow?",
"nodeSettings.notesInFlow.displayName": "Display Note in Flow?",
"nodeSettings.parameters": "Parameters",
"nodeSettings.retryOnFail.description": "If active, the node tries to execute again when it fails",
"nodeSettings.retryOnFail.displayName": "Retry On Fail",
Expand Down

0 comments on commit 13e3089

Please sign in to comment.