MNT Fix unit test #215
Merged
MNT Fix unit test #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/6/fix-test
branch
from
810735f to
a578de3
Compare
emteknetnz
commented
Jan 21, 2025
| @@ -24,4 +24,3 @@ public function objectsToDelete($context) | |||
| return []; | |||
| } | |||
| } | |||
|
|
|||
emteknetnz
commented
Jan 21, 2025
| @@ -246,7 +250,8 @@ public function testStaticPublishingTriggerOnExtension(): void | |||
| /** @var QueuedJobsTestService $service */ | |||
| $service = QueuedJobService::singleton(); | |||
|
|
|||
| $dataObject = DataObjectNoTrigger::create()->write(); | |||
| $dataObject = DataObjectNoTrigger::create(); | |||
| $dataObject->write(); | |||
There was a problem hiding this comment.
->write() returns an int, so we cannot chain it
I have no idea how this unit test used to pass
This was referenced Jan 21, 2025
| @@ -7,9 +7,10 @@ | |||
|
|
|||
| class DataObjectNoTrigger extends DataObject implements TestOnly | |||
| { | |||
| private static $table_name = 'StaticPublishQueue_DataObjectNoTrigger'; | |||
There was a problem hiding this comment.
I've created silverstripe/silverstripe-standards#15 to add a phpstan rule to resolve these going forward
GuySartorelli
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#357
Fixes https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/12879104438/job/35906085673#step:12:105
1) SilverStripe\StaticPublishQueue\Test\Extension\Engine\SiteTreePublishingEngineTest::testStaticPublishingTriggerOnExtension SilverStripe\ORM\Connect\DatabaseException: Couldn't run query: ...The unit test SiteTreePublishingEngineTest::testStaticPublishingTriggerOnExtension() doesn't exist on the latest minor branch 6.2, so targeting the 6 branch is correct