ENH Explicitly set i18n locale to en_US for supported modules #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will affect project behat tests as well (not common but they do exist) - please make sure to add a quick note about this in the 5.4 changelog. |
GuySartorelli
requested changes
Jan 21, 2025
emteknetnz
force-pushed
the
pulls/5/setlocale
branch
from
caaa8ef to
ea287f8
Compare
emteknetnz
changed the title
emteknetnz
force-pushed
the
pulls/5/setlocale
branch
from
ea287f8 to
5f3f63c
Compare
GuySartorelli
requested changes
Jan 22, 2025
GuySartorelli
requested changes
Jan 22, 2025
Comment on lines
+221
to
+223
| i18n::config()->set('default_locale', 'en_US'); | ||
| i18n::set_locale('en_US'); |
There was a problem hiding this comment.
Is the kernel booted by this stage? Will this work for the in-browser test instances which boot separate kernels from the one running the CLI instance?
There was a problem hiding this comment.
I think so though honestly I don't know. On my local which uses a headless chrome inside the docker container it seems to works fine i.e. broken behat tests linked to in the description now pass, and it also works fine on CI which is a similar sort of setup.
emteknetnz
force-pushed
the
pulls/5/setlocale
branch
2 times, most recently
from
6760344 to
c36e546
Compare
GuySartorelli
requested changes
Jan 23, 2025
emteknetnz
force-pushed
the
pulls/5/setlocale
branch
from
c36e546 to
34d29bb
Compare
GuySartorelli
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
LGTM
Failing CI unrelated (See silverstripe/silverstripe-framework#11576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#357
Similar to - using 3.x-dev of cwp-core causes the default locale to be en_GB instead of en_US
Fixes behat tests that break because of this e.g. https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/12879104438/job/35906088458
After merging, create 5.5 branch and tag 5.5.0
Needs silverstripe/silverstripe-framework#11576 merged for unit tests to pass
CI sink run with this PR https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/12938896222 - broken userforms behat is unrelated