-
-
Notifications
You must be signed in to change notification settings - Fork 10
Update @mui/x-date-pickers and Project Schedule settings #2876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2876 +/- ##
==========================================
+ Coverage 72.56% 72.61% +0.04%
==========================================
Files 262 264 +2
Lines 9976 9972 -4
Branches 1163 1162 -1
==========================================
+ Hits 7239 7241 +2
+ Misses 2398 2391 -7
- Partials 339 340 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After class comment on ProjectPickersDayf
Reviewed 1 of 7 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: 9 of 11 files reviewed, all discussions resolved (waiting on @imnasnainaec)
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
Reviewable status: 8 of 11 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jasonleenaylor)
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 7 files at r1, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
This is prerequisite for installing
material-react-tablefor #2875Changes:
@mui/x-date-pickers(v6)LocalizationProviderwrappers with oneDatePickersLocalizationProviderinAppLoggedIni18nextlanguage inDatePickersLocalizationProviderLocalizationProviderto theProjectSettingstests (now necessary for the schedule settings withmui/x-date-pickerscomponents without their own providers)CalendarPickerwithDateCalendardateandonChangepropsdefaultCalendarMonthtoreferenceDaterenderDaywith corresponding usage ofslotsandslotPropscustomDayRendererfor a commonProjectPickersDaycomponentstyle={{ width: 100 }}from button-holdingGrids (sizing that assumed English ui)useEffectwithModal.setAppElement("body");to prevent a console errorThis change is