-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add edit-version of PronunciationsCell #2615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
This comment was marked as resolved.
This comment was marked as resolved.
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 20 files at r1, 3 of 3 files at r2, 6 of 6 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/PronunciationsCell.tsx line 29 at r3 (raw file):
return props.audioFunctions ? ( <Pronunciations
This might be a little too clever... and spacer definitely seems like an inadequate name for what is going on here.
Skipping the record button in the inner Pronunciations by not passing uploadAudio wasn't easy for me to see.
I think we might need to discuss this and other possible design options.
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 14 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jasonleenaylor)
src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/PronunciationsCell.tsx line 29 at r3 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
This might be a little too clever... and spacer definitely seems like an inadequate name for what is going on here.
Skipping the record button in the inner Pronunciations by not passinguploadAudiowasn't easy for me to see.
I think we might need to discuss this and other possible design options.
Done.
jasonleenaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Resolves #1556 (but not #2616)
This change is