Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The label handling is broken #1

Closed
siimon opened this issue Dec 2, 2015 · 0 comments
Closed

The label handling is broken #1

siimon opened this issue Dec 2, 2015 · 0 comments

Comments

@siimon
Copy link
Owner

siimon commented Dec 2, 2015

Labels values should be dynamically handled in each metric and expose a "labels" function as guidelines describes
@siimon siimon closed this as completed Dec 7, 2015
siimon pushed a commit that referenced this issue Sep 6, 2016
@notkevin888 @siimon
Add post-timer labels (#1) (#30)
de29e47 
* Add post-timer labels (#1)

* add post-timer label support to summary

no reason to add a parameter into the first nested function, since that's only used in Summary.labels

* allow startLabels to be undefined

* add post-timer label support for gauges and histograms

* add extend to gauge.js

* add gauge tests (#2)

* add gauge tests

* add histogram tests

* add summary tests

* add timer + label documentation to readme

* add comments

* lint files
tcolgate referenced this issue in QubitProducts/prom-client Sep 19, 2016
@roylines
Merge pull request #1 from roylines/express-support
7694906 
Express support
tcolgate referenced this issue in QubitProducts/prom-client Sep 19, 2016
@tcolgate
Merge pull request #1 from KidkArolis/dont-create-labels-for-404s
4cb348f 
Avoid creating labels for each 404ed url
tcolgate referenced this issue in QubitProducts/prom-client Sep 19, 2016
@tcolgate
Merge pull request #1 from qubitdigital/updates
d0a0ddd 
Updates
lassic pushed a commit to lassic/prom-client that referenced this issue Sep 12, 2023
address PR comments siimon#1
fe4a561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@siimon