Add two strategies for disabling the client #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @SimenB, @siimon and @pnieuwenhuis to be potential reviewers |
|
Looks reasonable to me. @lclarkmichalek any thoughts? |
|
Nice bot guys 😆 Although I like this change, any chance of it being a PR upstream? 😄 |
|
@SimenB sorry for the disturbance! We need to tweak the settings a little haha We've made quite a few changes to our fork, I'll talk to Tristan about which ones we can propagate upstream. |
|
@SimenB once we merge it on this side, I'll try rebasing it on upstream and if it applies cleanly, I'll raise a PR. We've got a bunch of stuff in this fork now that I don't think would be generally desirable) |
|
LGMT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tcolgate thoughts?