Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Remove default subcommand hack #642

Merged
merged 5 commits into from
May 2, 2023
Merged

cli: Remove default subcommand hack #642

merged 5 commits into from
May 2, 2023

Conversation

woodruffw
Copy link
Member

Closes #636.

@woodruffw
_cli: remove optional command hack
4f8a877 
Closes #636.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw
_cli: improved --help output
84e4f16 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw
README: sigstore --help
d120a49 
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw added component:cli CLI components refactoring Refactoring tasks. chore labels May 1, 2023
@woodruffw woodruffw requested review from di and tnytown May 1, 2023 21:36
@woodruffw woodruffw self-assigned this May 1, 2023
@woodruffw
CHANGELOG: record changes
ae77a8e 
Signed-off-by: William Woodruff <[email protected]>
@tnytown
Copy link
Collaborator

tnytown commented May 1, 2023

The sigstore-python conformance adapter might need to convert verify to verify identity:

https://github.com/sigstore/sigstore-conformance/blob/06a7e51ed472954e17f2b3980185bc33f5b70f4f/sigstore-python-conformance

@woodruffw
Copy link
Member Author

The sigstore-python conformance adapter might need to convert verify to verify identity:

https://github.com/sigstore/sigstore-conformance/blob/06a7e51ed472954e17f2b3980185bc33f5b70f4f/sigstore-python-conformance

Yep, I think a610e0f will cover that.

@woodruffw woodruffw mentioned this pull request May 1, 2023
Closed
tetsuo-cpp
tetsuo-cpp approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tetsuo-cpp tetsuo-cpp merged commit d9b1c59 into main May 2, 2023
@tetsuo-cpp tetsuo-cpp deleted the ww/remove-subcommand-hack branch May 2, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetsuo-cpp tetsuo-cpp tetsuo-cpp approved these changes

@di di Awaiting requested review from di

@tnytown tnytown Awaiting requested review from tnytown

Assignees

@woodruffw woodruffw

Labels
chore component:cli CLI components refactoring Refactoring tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated sigstore verify -> sigstore verify identity alias
3 participants
@woodruffw @tnytown @tetsuo-cpp