Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated sigstore verify -> sigstore verify identity alias #636

Closed
woodruffw opened this issue Apr 26, 2023 · 2 comments · Fixed by #642
Closed

Remove deprecated sigstore verify -> sigstore verify identity alias #636

woodruffw opened this issue Apr 26, 2023 · 2 comments · Fixed by #642
Assignees
@woodruffw
Labels
enhancement New feature or request
Milestone
2.0

Comments

@woodruffw
Copy link
Member

As part of the 2.0 release, we should remove this deprecated alias: it complicates argument parsing significantly, and has been marked for deprecation since 1.0.

Expected new behavior: sigstore verify without a subcommand will produce a hard error and a suggested list of subcommands, rather than producing a deprecation warning and redirecting the user to sigstore verify identity.

CC @di for visibility.
@woodruffw woodruffw added the enhancement New feature or request label Apr 26, 2023
@woodruffw woodruffw added this to the 2.0 milestone Apr 26, 2023
@di
Copy link
Member

di commented Apr 26, 2023

Agreed!

@woodruffw woodruffw self-assigned this May 1, 2023
woodruffw added a commit that referenced this issue May 1, 2023
@woodruffw
_cli: remove optional command hack
4f8a877 
Closes #636.

Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw mentioned this issue May 1, 2023
Merged
@woodruffw
Copy link
Member Author

See #642.

tetsuo-cpp pushed a commit that referenced this issue May 2, 2023
@woodruffw
cli: Remove default subcommand hack (#642)
d9b1c59 
* _cli: remove optional command hack

Closes #636.

Signed-off-by: William Woodruff <[email protected]>

* _cli: improved `--help` output

Signed-off-by: William Woodruff <[email protected]>

* README: `sigstore --help`

Signed-off-by: William Woodruff <[email protected]>

* CHANGELOG: record changes

Signed-off-by: William Woodruff <[email protected]>

* test/integration: fixup subcommand handling

Signed-off-by: William Woodruff <[email protected]>

---------

Signed-off-by: William Woodruff <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodruffw woodruffw

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

cli: Remove default subcommand hack sigstore/sigstore-python
2 participants
@di @woodruffw