Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional bundle tests focused on tlog entries #97

Closed
steiza opened this issue Aug 18, 2023 · 0 comments · Fixed by #98
Closed

Additional bundle tests focused on tlog entries #97

steiza opened this issue Aug 18, 2023 · 0 comments · Fixed by #98
Labels
enhancement New feature or request

Comments

@steiza
Copy link
Member

steiza commented Aug 18, 2023

Description

Continue expanding test coverage on https://github.com/sigstore/sigstore-conformance/blob/main/test/test_bundle.py to cover inclusion proofs that don't include the log entry, as well as a different public key in the canonicalized body.
@steiza steiza added the enhancement New feature or request label Aug 18, 2023
steiza added a commit to steiza/sigstore-conformance that referenced this issue Aug 18, 2023
@steiza
For sigstore#97
04b1cb8 
Add bundle tests to cover tlog entries.  Cover inclusion proofs that don't include the log entry, as well as a different public key in the canonicalized body.

Signed-off-by: Zach Steindler <[email protected]>
@steiza steiza mentioned this issue Aug 18, 2023
Merged
woodruffw pushed a commit that referenced this issue Aug 21, 2023
@steiza
For #97 (#98)
6c958ac 
Add bundle tests to cover tlog entries.  Cover inclusion proofs that don't include the log entry, as well as a different public key in the canonicalized body.

Signed-off-by: Zach Steindler <[email protected]>
@jku jku mentioned this issue Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add bundle tests to increase coverage of tlog entries steiza/sigstore-conformance
1 participant
@steiza