-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace option for same attestation #1039
Conversation
Signed-off-by: Furkan <[email protected]> Signed-off-by: Batuhan Apaydın <[email protected]>
we also added a target for |
Close!
|
ce0c14d
to
74dc60a
Compare
seems okay right now, thanks, I missed it due to build tags 🤦 |
Signed-off-by: Batuhan Apaydın <[email protected]>
@dlorenc should we do the same for signatures? |
@@ -211,6 +211,13 @@ func (si *signedImage) Attestations() (oci.Signatures, error) { | |||
return base, nil | |||
} | |||
} | |||
if si.so.ro != nil { | |||
replace, err := si.so.ro.Replace(base, si.att) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these paths aren't covered by current unit tests, can we get some unit tests for these, please? 🙏
Signed-off-by: Furkan [email protected]
feat: replace option for same attestation
Signed-off-by: Batuhan Apaydın [email protected]
Summary
replace option for same attestation
Ticket Link
Fixes #923
Release Note
Huge thanks tho @imjasonh !!
cc: @JimBugwadia @dlorenc @cpanato