Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to replace attestations #923

Closed
JimBugwadia opened this issue Oct 19, 2021 · 5 comments · Fixed by #1039
Closed

option to replace attestations #923

JimBugwadia opened this issue Oct 19, 2021 · 5 comments · Fixed by #1039
Labels
enhancement New feature or request

Comments

@JimBugwadia
Copy link
Contributor

Description

Provide a way to replace (vs. append) attestations.

Currently the same attestation type can be appended multiple times. A proposal is to support a --replace which would change the behavior to replace an attestation of the same type instead of appending it to the existing list of attestations.

Slack discussion at: https://sigstore.slack.com/archives/C01PZKDL4DP/p1633463916305100.

@JimBugwadia JimBugwadia added the enhancement New feature or request label Oct 19, 2021
@JimBugwadia
Copy link
Contributor Author

I can make the changes, if adding a --replace seems like a good approach.

@dlorenc
Copy link
Member

dlorenc commented Oct 21, 2021

We could do this on both attestations and signatures I think. It makes sense to me.

@JimBugwadia
Copy link
Contributor Author

Thanks, @dlorenc! Please assign to me and I will work on a PR.

@developer-guy
Copy link
Member

developer-guy commented Nov 9, 2021

amazing thought @JimBugwadia 👏 , we (w/@Dentrax @erkanzileli) are available for a while, so, we can work on this issue if you let us do that 🤩

@JimBugwadia
Copy link
Contributor Author

@developer-guy please proceed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants