Enable reconstruction for nodes custodying more than 50% of columns and instrument tracing #8052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
added
ready-for-review
commit a209f72 Author: Eitan Seri- Levi <[email protected]> Date: Mon Sep 15 20:18:40 2025 -0700 remove publish flag commit a4044a9 Author: Eitan Seri- Levi <[email protected]> Date: Mon Sep 15 20:14:34 2025 -0700 remove publish flag commit eab7693 Author: Eitan Seri- Levi <[email protected]> Date: Mon Sep 15 18:56:19 2025 -0700 linting commit a3e0aec Author: Eitan Seri- Levi <[email protected]> Date: Mon Sep 15 18:53:23 2025 -0700 Delete reconstruction when processesing column rpc requests
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
…e trigger to attempt reconstruction if column count is >= 50%.
jimmygchen
changed the title
jimmygchen
added
ready-for-review
|
This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏 |
mergify
bot
added
waiting-on-author
# Conflicts: # beacon_node/network/src/network_beacon_processor/gossip_methods.rs # beacon_node/network/src/network_beacon_processor/mod.rs
jimmygchen
added
ready-for-review
eserilev
reviewed
Sep 16, 2025
Comment on lines
1056
to
1063
| if !self | ||
| .chain | ||
| .data_availability_checker | ||
| .custody_context() | ||
| .should_attempt_reconstruction( | ||
| slot.epoch(T::EthSpec::slots_per_epoch()), | ||
| &self.chain.spec, | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| if !self | |
| .chain | |
| .data_availability_checker | |
| .custody_context() | |
| .should_attempt_reconstruction( | |
| slot.epoch(T::EthSpec::slots_per_epoch()), | |
| &self.chain.spec, | |
| ) | |
| if self | |
| .chain | |
| .data_availability_checker | |
| .custody_context() | |
| .should_attempt_reconstruction( | |
| slot.epoch(T::EthSpec::slots_per_epoch()), | |
| &self.chain.spec, | |
| ) |
Member
|
other than my comment, this looks good to me |
eserilev
approved these changes
Sep 16, 2025
jimmygchen
added
ready-for-merge
6 tasks
Member
Author
|
@mergify dequeue |
|
This pull request has been removed from the queue for the following reason: The pull request #8052 has been manually updated. If you want to requeue this pull request, you can post a |
☑️ The pull request is not queued |
jtraglia
pushed a commit
to jtraglia/lighthouse
that referenced
this pull request
Sep 16, 2025
…nd instrument tracing (sigp#8052) Co-Authored-By: Jimmy Chen <[email protected]> Co-Authored-By: Jimmy Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8018 and more below: