-
Notifications
You must be signed in to change notification settings - Fork 955
Remove column reconstruction when processing rpc requests #8051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 4 commits into
sigp:unstable
from
eserilev:delete-reconstruction-over-rpc
Sep 16, 2025
Merged
Remove column reconstruction when processing rpc requests #8051
mergify
merged 4 commits into
sigp:unstable
from
eserilev:delete-reconstruction-over-rpc
Sep 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
reviewed
Sep 16, 2025
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
jimmygchen
approved these changes
Sep 16, 2025
Member
jimmygchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
14 tasks
jimmygchen
added a commit
to jimmygchen/lighthouse
that referenced
this pull request
Sep 16, 2025
commit a209f72 Author: Eitan Seri- Levi <[email protected]> Date: Mon Sep 15 20:18:40 2025 -0700 remove publish flag commit a4044a9 Author: Eitan Seri- Levi <[email protected]> Date: Mon Sep 15 20:14:34 2025 -0700 remove publish flag commit eab7693 Author: Eitan Seri- Levi <[email protected]> Date: Mon Sep 15 18:56:19 2025 -0700 linting commit a3e0aec Author: Eitan Seri- Levi <[email protected]> Date: Mon Sep 15 18:53:23 2025 -0700 Delete reconstruction when processesing column rpc requests
jtraglia
pushed a commit
to jtraglia/lighthouse
that referenced
this pull request
Sep 16, 2025
Co-Authored-By: Eitan Seri- Levi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the node from attempting to reconstruct data columns during RPC request processing. Instead allow sync to send out requests to fetch missing columns. Reconstruction is a computationally expensive task, especially at higher blob counts and should be avoided when possible.