Skip to content

Remove extern crate - #5922

Merged
mergify[bot] merged 1 commit into
sigp:unstablefrom
michaelsproul:extern-crate
Jun 17, 2024
Merged

Remove extern crate#5922
mergify[bot] merged 1 commit into
sigp:unstablefrom
michaelsproul:extern-crate

Conversation

@michaelsproul

@michaelsproul michaelsproul commented Jun 13, 2024

Copy link
Copy Markdown
Member

Proposed Changes

As of Rust 2018 (which we use), extern crate is unnecessary, and kinda janky.

This PR removes all uses of extern crate in favour of regular uses.

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! labels Jun 13, 2024
realbigsean
realbigsean approved these changes Jun 13, 2024
View reviewed changes

@realbigsean realbigsean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realbigsean

realbigsean commented Jun 13, 2024

Copy link
Copy Markdown
Member

@mergify queue

@mergify

mergify Bot commented Jun 13, 2024 •
edited
Loading

Copy link
Copy Markdown

queue

🛑 The pull request has been removed from the queue default

Details

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify Bot added a commit that referenced this pull request Jun 13, 2024
@mergify
Merge of #5922
fd6dd0b
@mergify mergify Bot mentioned this pull request Jun 13, 2024
Closed
5 tasks
@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Jun 17, 2024
@realbigsean

realbigsean commented Jun 17, 2024

Copy link
Copy Markdown
Member

@mergify requeue

@mergify

mergify Bot commented Jun 17, 2024

Copy link
Copy Markdown

requeue

✅ This pull request will be re-embarked automatically

Details

The followup queue command will be automatically executed to re-embark the pull request

@mergify

mergify Bot commented Jun 17, 2024 •
edited
Loading

Copy link
Copy Markdown

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 21f3a19

mergify Bot added a commit that referenced this pull request Jun 17, 2024
@mergify
Merge of #5922
e5b5fcd
This was referenced Jun 17, 2024
Closed
Merged
Merged
Merged
@mergify
mergify Bot merged commit 21f3a19 into sigp:unstable Jun 17, 2024
@AgeManning AgeManning mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@realbigsean realbigsean realbigsean approved these changes

Assignees

No one assigned

Labels

code-quality low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelsproul @realbigsean @jimmygchen