Fix CommandLineTest port conflicts on CI - #5908
Merged
Merged
Conversation
jimmygchen
added
test improvement
jimmygchen
marked this pull request as ready for review
June 10, 2024 22:16
jimmygchen
changed the title
CommandLineTest port conflicts on CI
michaelsproul
approved these changes
Jun 14, 2024
michaelsproul
left a comment
michaelsproul
left a comment
Member
There was a problem hiding this comment.
Nice, this should save us some hassle with these tests in future too
michaelsproul
added
ready-for-merge
Member
|
@mergify queue |
✅ The pull request has been merged automaticallyDetailsThe pull request has been merged automatically at bc044ed |
This was referenced Jun 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fixes recurring port conflicts in beacon node command line tests. This PR changes the
CommandLineTestto not start aProductionBeaconNode(and HTTP server) by default - which isn't strictly necessary as we're just verifying command line configurations - so that it doesn't fail due to port conflicts.https://github.com/sigp/lighthouse/actions/runs/9446884349/job/26017488730