Skip to content

[chore] Cherry pick sqlserver receiver fix#7322

Merged
pjanotti merged 1 commit into
signalfx:mainfrom
XSAM:cherry-pick-sqlserver-fix
Mar 9, 2026
Merged

[chore] Cherry pick sqlserver receiver fix#7322
pjanotti merged 1 commit into
signalfx:mainfrom
XSAM:cherry-pick-sqlserver-fix

Conversation

@XSAM

@XSAM XSAM commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

@XSAM XSAM requested review from a team as code owners March 9, 2026 16:37
Copilot AI review requested due to automatic review settings March 9, 2026 16:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Cherry-picks an upstream fix for the sqlserverreceiver by updating dependency versions in this collector distribution, ensuring the build pulls in the corrected receiver implementation.

Changes:

  • Bump github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sqlserverreceiver to a newer pseudo-version containing the fix.
  • Update go.opentelemetry.io/otel, otel/metric, and otel/trace from v1.40.0 to v1.41.0.
  • Regenerate go.sum to reflect the updated module versions/hashes.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
go.mod Updates required module versions for sqlserverreceiver and OTel-Go packages.
go.sum Updates dependency checksums to match the new versions selected by go.mod.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread go.mod
Comment on lines +778 to 780
go.opentelemetry.io/otel v1.41.0
go.opentelemetry.io/otel/sdk v1.40.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.40.0 // indirect

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.opentelemetry.io/otel is bumped to v1.41.0, but the rest of the OTel-Go modules in this require block remain at v1.40.0 (e.g., go.opentelemetry.io/otel/sdk and several exporters earlier in go.mod). Mixing OTel module versions can make dependency management harder and increases the risk of subtle incompatibilities; consider upgrading the remaining go.opentelemetry.io/otel* modules to v1.41.0 (or, if v1.41.0 is not intended here, keep otel/trace/metric at v1.40.0 for consistency) and re-running go mod tidy.

Copilot uses AI. Check for mistakes.
@XSAM XSAM requested a review from a team as a code owner March 9, 2026 16:46
Copilot AI review requested due to automatic review settings March 9, 2026 16:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .chloggen/cherry-pick-sqlserver-fix.yaml
@codecov

codecov Bot commented Mar 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 33.03%. Comparing base (c1607dc) to head (b8bdd42).

❌ Your project check has failed because the head coverage (33.03%) is below the target coverage (35.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7322      +/-   ##
==========================================
- Coverage   33.05%   33.03%   -0.03%     
==========================================
  Files         332      332              
  Lines       23506    23506              
==========================================
- Hits         7771     7766       -5     
- Misses      14835    14839       +4     
- Partials      900      901       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@XSAM XSAM force-pushed the cherry-pick-sqlserver-fix branch from b8bdd42 to b1f7c96 Compare March 9, 2026 18:17
@pjanotti pjanotti merged commit 085a94c into signalfx:main Mar 9, 2026
39 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
@XSAM XSAM deleted the cherry-pick-sqlserver-fix branch March 9, 2026 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants