[chore] Cherry pick sqlserver receiver fix#7322
Conversation
There was a problem hiding this comment.
Pull request overview
Cherry-picks an upstream fix for the sqlserverreceiver by updating dependency versions in this collector distribution, ensuring the build pulls in the corrected receiver implementation.
Changes:
- Bump
github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sqlserverreceiverto a newer pseudo-version containing the fix. - Update
go.opentelemetry.io/otel,otel/metric, andotel/tracefromv1.40.0tov1.41.0. - Regenerate
go.sumto reflect the updated module versions/hashes.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Updates required module versions for sqlserverreceiver and OTel-Go packages. |
| go.sum | Updates dependency checksums to match the new versions selected by go.mod. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| go.opentelemetry.io/otel v1.41.0 | ||
| go.opentelemetry.io/otel/sdk v1.40.0 // indirect | ||
| go.opentelemetry.io/otel/sdk/metric v1.40.0 // indirect |
There was a problem hiding this comment.
go.opentelemetry.io/otel is bumped to v1.41.0, but the rest of the OTel-Go modules in this require block remain at v1.40.0 (e.g., go.opentelemetry.io/otel/sdk and several exporters earlier in go.mod). Mixing OTel module versions can make dependency management harder and increases the risk of subtle incompatibilities; consider upgrading the remaining go.opentelemetry.io/otel* modules to v1.41.0 (or, if v1.41.0 is not intended here, keep otel/trace/metric at v1.40.0 for consistency) and re-running go mod tidy.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (33.03%) is below the target coverage (35.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7322 +/- ##
==========================================
- Coverage 33.05% 33.03% -0.03%
==========================================
Files 332 332
Lines 23506 23506
==========================================
- Hits 7771 7766 -5
- Misses 14835 14839 +4
- Partials 900 901 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b8bdd42 to
b1f7c96
Compare
Pulling open-telemetry/opentelemetry-collector-contrib#46484