[receiver/sqlserver] Fix host.name attribute with datasource config#46484
Merged
ChrsMark merged 5 commits intoMar 5, 2026
Merged
Conversation
github-actions
Bot
added
receiver/sqlserver
Run Windows
Fixes open-telemetry#42355 When using the datasource configuration option, the host.name resource attribute is now correctly extracted from the datasource connection string using the existing parseDataSource method.
himanshu130700
force-pushed
the
fix-sqlserver-hostname-datasource
branch
from
525f41e to
a9f0d3e
Compare
himanshu130700
force-pushed
the
fix-sqlserver-hostname-datasource
branch
from
0cf961d to
53b0c13
Compare
Contributor
|
This issue stems from a bug in how MS code parses the datasource string and fails to set the config.Host value under some circumstances, so I have my own pr here that should cover the issue from the MS bug angle. |
XSAM
approved these changes
Mar 4, 2026
Contributor
Author
|
Hello @crobert-1, can we please merge the PR |
crobert-1
added
the
ready to merge
ChrsMark
approved these changes
Mar 5, 2026
Contributor
|
Thank you for your contribution @himanshu130700! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
antonio-mazzini
pushed a commit
to antonio-mazzini/opentelemetry-collector-contrib
that referenced
this pull request
Mar 5, 2026
…pen-telemetry#46484) Fixes open-telemetry#42355 When using the datasource configuration option, the host.name resource attribute is now correctly extracted from the datasource connection string using the existing parseDataSource method.
This was referenced Mar 7, 2026
avleentwilio
pushed a commit
to avleentwilio/opentelemetry-collector-contrib
that referenced
this pull request
Apr 1, 2026
…pen-telemetry#46484) Fixes open-telemetry#42355 When using the datasource configuration option, the host.name resource attribute is now correctly extracted from the datasource connection string using the existing parseDataSource method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42355
When using the datasource configuration option, the host.name resource attribute is now correctly extracted from the datasource connection string using the existing parseDataSource method.