Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump opentelemetry-okhttp-3.0 from 1.6.2-alpha to 1.7.0-alpha #176

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 20, 2021

Bumps opentelemetry-okhttp-3.0 from 1.6.2-alpha to 1.7.0-alpha.

Release notes

Sourced from opentelemetry-okhttp-3.0's releases.

Release v1.6.2

This is a patch release on the previous 1.6.0 and 1.6.1 releases, fixing the one issue below that arose during the 1.6.1 patch release.

If you are not affected by this, you do not need to update.

🛠️ Bug fixes

  • The 1.6.1 patch release was not backwards compatible with javaagent extensions built against 1.6.0 (#4245)
Changelog

Sourced from opentelemetry-okhttp-3.0's changelog.

Changelog

Version 1.7.0 - 2021-10-19

📈 Enhancements

  • Change the default javaagent artifact to have exporters, introduce new -slim artifact, and deprecate the -all artifact (#4106)
  • Support jlinked images without jdk.unsupported module (#4154) (#4124)
  • Added experimental option to suppress messaging receive spans (#4187) (#4204)
  • Refine 404 handling in Restlet instrumentation (#4206)
  • Remove dynamo db.name attribute (#4208)
  • Remove capturing http.url in server instrumentation in favor of http.scheme, http.host and http.target (#4209)
  • Intern db info to reduce memory consumption (#4263)
  • Better JAX-RS async cancel handling (#4279)
  • Extract HTTP request/response headers as span attributes (#4237, #4309, #4320, #4321, #4328, #4395)
  • Support kafka streams 3 (#4236)
  • AWS lambda - improvements in custom type handling in wrappers, SQS event wrapper added (#4254)
  • Add code attributes to quartz spans (#4332)
  • Collect more attributes from servlet instrumenter (#4356)
  • Allow reactor instrumentation to pick up spans from reactor context (#4159)
  • Hide virtual field accessor interface methods from reflection (#4390)

🛠️ Bug fixes

  • Fix spring context reload issue (#4051)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [opentelemetry-okhttp-3.0](https://github.com/open-telemetry/opentelemetry-java-instrumentation) from 1.6.2-alpha to 1.7.0-alpha.
- [Release notes](https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/CHANGELOG.md)
- [Commits](https://github.com/open-telemetry/opentelemetry-java-instrumentation/commits)

---
updated-dependencies:
- dependency-name: io.opentelemetry.instrumentation:opentelemetry-okhttp-3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from a team as code owners October 20, 2021 10:11
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Oct 20, 2021
@mateuszrzeszutek
Copy link
Contributor

ERROR:/home/runner/.gradle/caches/modules-2/files-2.1/io.opentelemetry.instrumentation/opentelemetry-instrumentation-api/1.7.0-alpha/d5e265ff68ba58266a61ef62730e142e32635a3f/opentelemetry-instrumentation-api-1.7.0-alpha.jar: D8: com.android.tools.r8.internal.n1: MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26)

That is strange, I don't think we use MethodHandles at all in the instrumentation api.

@laurit
Copy link
Contributor

laurit commented Oct 20, 2021

ERROR:/home/runner/.gradle/caches/modules-2/files-2.1/io.opentelemetry.instrumentation/opentelemetry-instrumentation-api/1.7.0-alpha/d5e265ff68ba58266a61ef62730e142e32635a3f/opentelemetry-instrumentation-api-1.7.0-alpha.jar: D8: com.android.tools.r8.internal.n1: MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26)

That is strange, I don't think we use MethodHandles at all in the instrumentation api.

This jar includes shaded caffeine3 that uses it

@jkwatson
Copy link
Contributor

ERROR:/home/runner/.gradle/caches/modules-2/files-2.1/io.opentelemetry.instrumentation/opentelemetry-instrumentation-api/1.7.0-alpha/d5e265ff68ba58266a61ef62730e142e32635a3f/opentelemetry-instrumentation-api-1.7.0-alpha.jar: D8: com.android.tools.r8.internal.n1: MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26)

That is strange, I don't think we use MethodHandles at all in the instrumentation api.

This jar includes shaded caffeine3 that uses it

Is this something new with 1.7.0? If so, we'll need to get that reverted/fixed for Android, unfortunately.

@mateuszrzeszutek
Copy link
Contributor

Is this something new with 1.7.0? If so, we'll need to get that reverted/fixed for Android, unfortunately.

Yep, caffeine3 seems to have been introduced in 1.7.0 - open-telemetry/opentelemetry-java-instrumentation#4154

Support jlinked images without jdk.unsupported module (#4154) (#4124)

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 28, 2021

A newer version of io.opentelemetry.instrumentation:opentelemetry-okhttp-3.0 exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@jkwatson
Copy link
Contributor

closing as this will, at the minimum, require some updates to our implementation along with it. and, it's still broken. :(

@jkwatson jkwatson closed this Oct 28, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 28, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/gradle/io.opentelemetry.instrumentation-opentelemetry-okhttp-3.0-1.7.0-alpha branch October 28, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants