Use caffeine3 on jdk11 and caffeine2 on older jdks #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
anuraaga
reviewed
Sep 17, 2021
|
|
||
| package io.opentelemetry.instrumentation.api.caching; | ||
|
|
||
| import io.opentelemetry.instrumentation.api.internal.shaded.caffeine2.cache.Caffeine; |
There was a problem hiding this comment.
I was hoping it's possible to use the same package but put caffeine3 into the mrjar folder. And with just one implementation jvm would automatically pick the correct one. Could it work?
There was a problem hiding this comment.
Unfortunately afaik boot loader does not support mrjars.
Co-authored-by: Mateusz Rzeszutek <[email protected]>
laurit
changed the title
anuraaga
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4092