Skip to content

feat: add yt-dlp to package lists in default.nix and homebrew.nix - #959

Merged
shunkakinoki merged 1 commit into
mainfrom
fix-build
Feb 27, 2026
Merged

feat: add yt-dlp to package lists in default.nix and homebrew.nix#959
shunkakinoki merged 1 commit into
mainfrom
fix-build

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Feb 27, 2026

Copy link
Copy Markdown
Owner

Entire-Checkpoint: 1ffdcbb52d73


Summary by cubic

Added yt-dlp to home-manager packages and the nix-darwin Homebrew formula list so the video downloader is installed by default across environments.

Written for commit beaaf4a. Summary will update on new commits.

@mesa-dot-dev

mesa-dot-dev Bot commented Feb 27, 2026

Copy link
Copy Markdown

You do not have enough credits to review this pull request. Please purchase more credits to continue.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the yt-dlp utility into the system's package management configurations. It ensures yt-dlp is available through Homebrew on Nix-Darwin systems and adjusts its placement within the Home Manager package definitions for better organization.

Highlights

  • Package Relocation: The yt-dlp package entry was relocated within the home-manager/packages/default.nix file, moving it from one list to another.
  • New Package Addition: The yt-dlp package was added to the Homebrew package list in nix-darwin/config/homebrew.nix.
Changelog
  • home-manager/packages/default.nix
    • Relocated yt-dlp from the primary package list to a different section within the file.
  • nix-darwin/config/homebrew.nix
    • Added yt-dlp to the list of Homebrew packages.
Activity
  • No activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai

coderabbitai Bot commented Feb 27, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9f27178 and beaaf4a.

📒 Files selected for processing (2)
  • home-manager/packages/default.nix
  • nix-darwin/config/homebrew.nix

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Reorganized system package configuration to conditionally install yt-dlp on desktop environments.
    • Updated macOS package manager configuration to include yt-dlp.

Walkthrough

The pull request moves yt-dlp from the top-level packages list to the desktop-conditional block in home-manager configuration and adds yt-dlp to the Homebrew packages list in nix-darwin configuration.

Changes

Cohort / File(s) Summary
Home-manager Package Reorganization
home-manager/packages/default.nix
Relocated yt-dlp from unconditional top-level packages to the lib.optionals isDesktop conditional block, making it desktop-specific.
macOS Homebrew Configuration
nix-darwin/config/homebrew.nix
Added yt-dlp to the brews package list for macOS system installation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A hopper hops with glee, yt-dlp finds its way,
From common heights to desktop lands, where videos will play,
On Darwin's brew, a package true, now gathered with the rest,
Configuration cleaned and keen, the dotfiles pass the test! 📹

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mesa-dot-dev

mesa-dot-dev Bot commented Feb 27, 2026

Copy link
Copy Markdown

Mesa Description

TL;DR

Added yt-dlp to the package lists in default.nix and homebrew.nix.

What changed?

yt-dlp has been added to the package definitions, specifically in default.nix and homebrew.nix. (File summaries are unavailable for more detailed changes.)

Description generated by Mesa. Update settings

@shunkakinoki
shunkakinoki merged commit fec33b5 into main Feb 27, 2026
27 of 28 checks passed
@shunkakinoki
shunkakinoki deleted the fix-build branch February 27, 2026 08:50

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the installation of yt-dlp to be platform-specific. It is now installed via Nix packages on Linux desktops and via Homebrew on macOS. The changes are consistent with the existing structure of the configuration. However, I've added a comment regarding the removal of yt-dlp from non-desktop Linux systems, which might be an unintended side effect.

wl-clip-persist
wl-clipboard
wtype
yt-dlp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Placing yt-dlp under the isLinux && isDesktop condition removes it from non-desktop Linux environments (e.g., servers). As yt-dlp is a command-line utility, it can be useful in such environments. If its availability is desired on all Linux systems, consider placing it in the lib.optionals stdenv.isLinux block (lines 97-121) instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant