Add graphviz to Homebrew brews list - #336
Conversation
Summary of ChangesHello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change adds the "graphviz" package to the homebrew package list in the nix-darwin configuration. This is a single-line addition to the existing brews attribute, enabling graphviz installation when the system configuration is applied. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the graphviz package to the list of Homebrew brews managed by nix-darwin configuration. Graphviz is a graph visualization software toolkit commonly used for rendering diagrams and network graphs.
Key Changes
- Added "graphviz" entry to the homebrew.nix brews list in alphabetical order
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
nix-darwin/config/homebrew.nix(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.nix
📄 CodeRabbit inference engine (CLAUDE.md)
Format all Nix files with nixfmt
**/*.nix: Nix: Use 2 spaces for indentation
Nix: Keep line length under 100 characters
Nix: Sort attribute sets alphabetically
Nix: Use consistent spacing around operators
Nix: Format lists and sets consistentlyFollow the Nix expression language style guide
Files:
nix-darwin/config/homebrew.nix
nix-darwin/**
📄 CodeRabbit inference engine (CLAUDE.md)
Use Homebrew only for macOS-specific applications within nix-darwin configs
Keep Darwin-specific configurations under nix-darwin/
Files:
nix-darwin/config/homebrew.nix
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: shunkakinoki/dotfiles PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-28T16:25:07.125Z
Learning: Applies to nix-darwin/** : Use Homebrew only for macOS-specific applications within nix-darwin configs
Learnt from: CR
Repo: shunkakinoki/dotfiles PR: 0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-28T16:26:18.516Z
Learning: Applies to nix-darwin/** : Keep Darwin-specific configurations under nix-darwin/
📚 Learning: 2025-09-28T16:25:07.125Z
Learnt from: CR
Repo: shunkakinoki/dotfiles PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-09-28T16:25:07.125Z
Learning: Applies to nix-darwin/** : Use Homebrew only for macOS-specific applications within nix-darwin configs
Applied to files:
nix-darwin/config/homebrew.nix
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: nix-nixos
- GitHub Check: nix-linux
- GitHub Check: nix-darwin
- GitHub Check: docker-build-push (linux/arm64, arm64, ubuntu-24.04-arm)
- GitHub Check: docker-build-push (linux/amd64, amd64, ubuntu-latest)
- GitHub Check: e2e-run (Ubuntu, ubuntu-latest)
- GitHub Check: e2e-run (MacOS, macos-latest)
- GitHub Check: e2e-run (NixOS, ubuntu-latest)
| "gemini-cli" | ||
| "geth" | ||
| "gnupg" | ||
| "graphviz" |
There was a problem hiding this comment.
Consider installing graphviz via Nix instead of Homebrew.
Graphviz is a cross-platform tool available in nixpkgs and should be installed via Nix rather than Homebrew, as it's not a macOS-specific application.
Based on learnings and coding guidelines.
Apply this diff to remove it from the Homebrew brews list:
- "graphviz"Then add it to your Nix configuration (e.g., in a packages list) instead:
environment.systemPackages = with pkgs; [
graphviz
# ... other packages
];🤖 Prompt for AI Agents
In nix-darwin/config/homebrew.nix around line 29 the Homebrew brews list
contains "graphviz" which should be removed because Graphviz belongs in nixpkgs;
remove that entry from the brews list and instead add graphviz to your Nix
environment packages (e.g., add graphviz to environment.systemPackages = with
pkgs; [ graphviz ... ] in your Nix configuration).
Mesa DescriptionTL;DRAdded What changed?The file summaries are undefined, so a detailed list of changes by file cannot be provided. However, based on the PR title and summary, Description generated by Mesa. Update settings |
Include graphviz in the list of available Homebrew brews.
Summary by cubic
Added graphviz to the nix-darwin Homebrew brews list so DOT diagram rendering is available by default on macOS dev machines.
Written for commit 3e86e00. Summary will update automatically on new commits.