Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions overlays/default.nix
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{ inputs }:
let
# Override clawdbot source to v2026.1.21
# Override clawdbot source to v2026.1.23
clawdbotSourceOverride = {
owner = "clawdbot";
repo = "clawdbot";
rev = "80c1edc3ff43b3bd3b7b545eed79f303d992f7dc";
hash = "sha256-IsTNC79KXKL7ByBh7zUmH6qXx0YFdiQ4a4TI40C53U8=";
rev = "c9e98376b3e5d3a2f3a1639be53bd850f6d3acbf";
hash = "sha256-egAHjt6CHz79fStSg42opVPHjquurAa6FcGpNkQ0UtA=";
pnpmDepsHash = "sha256-tGzKcCiZNlWlKMNNFmxcFpIvO92G9myhM+OYaGea4hw=";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rev for the clawdbot source has been updated, but the pnpmDepsHash remains unchanged. It is highly likely that pnpm-lock.yaml has changed between these versions, which would necessitate a new pnpmDepsHash. The current hash may be stale and could cause build failures for anyone without the old dependencies cached. Please verify and update this hash. The scripts/upgrade-overlays.sh script should be able to compute the correct hash.

Copilot AI Jan 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pnpmDepsHash has not been updated as part of this version upgrade. According to the upgrade script (scripts/upgrade-overlays.sh lines 189-195), if the automated hash computation fails, it keeps the old value and warns that manual verification may be needed. Please verify that the pnpm dependencies genuinely haven't changed between v2026.1.21 and v2026.1.23, or update this hash if needed. An incorrect pnpmDepsHash could cause build failures or fetch incorrect dependencies.

Copilot uses AI. Check for mistakes.
};
# Override clawdbot-app to v2026.1.21 (fixes broken app package)
# Override clawdbot-app to v2026.1.23 (fixes broken app package)
clawdbotAppOverride = {
version = "2026.1.21";
url = "https://github.com/clawdbot/clawdbot/releases/download/v2026.1.21/Clawdbot-2026.1.21.zip";
hash = "sha256-EhGRakuN0dhEkXvrOd21t79odf4T2jY7oKFRubLqGbI=";
version = "2026.1.23";
url = "https://github.com/clawdbot/clawdbot/releases/download/v2026.1.23/Clawdbot-2026.1.23.zip";
hash = "sha256-HGN8yfDHkoP30YBk11U7kugE6RVkDs9oGwyUdLztToQ=";
};
Comment on lines +3 to 16

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's significant duplication of the version string (2026.1.23) and related values. It appears in comments, clawdbotAppOverride, and again as clawdbotVersion on line 25. This makes version upgrades brittle, as evidenced by the multiple sed and awk commands in the upgrade-overlays.sh script.

To improve maintainability, consider defining the version and related hashes once in the top-level let block and referencing these variables throughout the file. This would make the code DRY and simplify future upgrades.

in
[
Expand All @@ -22,7 +22,7 @@ in
(
final: prev:
let
clawdbotVersion = "2026.1.21";
clawdbotVersion = "2026.1.23";
basePkgs = import "${inputs.nix-clawdbot}/nix/packages" {
pkgs = prev;
sourceInfo = clawdbotSourceOverride;
Expand Down
Loading