chore: upgrade overlays - #662
Conversation
|
You do not have enough credits to review this pull request. Please purchase more credits to continue. |
Summary of ChangesHello @shunkakinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an automated update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Mesa DescriptionTL;DRAutomated upgrade of Nix overlays. What changed?File summaries are not available, but the changes relate to an automated overlay upgrade. Description generated by Mesa. Update settings |
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughBumps clawdbot version from v2026.1.21 to v2026.1.23 in the Nix overlay, updating corresponding source revision hashes and clawdbot-app metadata to match the new release. No control flow or functional changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request automates the upgrade of the clawdbot overlay. The changes correctly update the version numbers, revision, and hashes for the new version.
I have two main points of feedback:
- A potential issue with an unchanged
pnpmDepsHash, which could lead to build failures. - A suggestion to refactor the overlay file to reduce duplication and improve maintainability, which would also simplify the upgrade script.
Please see the detailed comments in the code.
| hash = "sha256-IsTNC79KXKL7ByBh7zUmH6qXx0YFdiQ4a4TI40C53U8="; | ||
| rev = "c9e98376b3e5d3a2f3a1639be53bd850f6d3acbf"; | ||
| hash = "sha256-egAHjt6CHz79fStSg42opVPHjquurAa6FcGpNkQ0UtA="; | ||
| pnpmDepsHash = "sha256-tGzKcCiZNlWlKMNNFmxcFpIvO92G9myhM+OYaGea4hw="; |
There was a problem hiding this comment.
The rev for the clawdbot source has been updated, but the pnpmDepsHash remains unchanged. It is highly likely that pnpm-lock.yaml has changed between these versions, which would necessitate a new pnpmDepsHash. The current hash may be stale and could cause build failures for anyone without the old dependencies cached. Please verify and update this hash. The scripts/upgrade-overlays.sh script should be able to compute the correct hash.
| # Override clawdbot source to v2026.1.23 | ||
| clawdbotSourceOverride = { | ||
| owner = "clawdbot"; | ||
| repo = "clawdbot"; | ||
| rev = "80c1edc3ff43b3bd3b7b545eed79f303d992f7dc"; | ||
| hash = "sha256-IsTNC79KXKL7ByBh7zUmH6qXx0YFdiQ4a4TI40C53U8="; | ||
| rev = "c9e98376b3e5d3a2f3a1639be53bd850f6d3acbf"; | ||
| hash = "sha256-egAHjt6CHz79fStSg42opVPHjquurAa6FcGpNkQ0UtA="; | ||
| pnpmDepsHash = "sha256-tGzKcCiZNlWlKMNNFmxcFpIvO92G9myhM+OYaGea4hw="; | ||
| }; | ||
| # Override clawdbot-app to v2026.1.21 (fixes broken app package) | ||
| # Override clawdbot-app to v2026.1.23 (fixes broken app package) | ||
| clawdbotAppOverride = { | ||
| version = "2026.1.21"; | ||
| url = "https://github.com/clawdbot/clawdbot/releases/download/v2026.1.21/Clawdbot-2026.1.21.zip"; | ||
| hash = "sha256-EhGRakuN0dhEkXvrOd21t79odf4T2jY7oKFRubLqGbI="; | ||
| version = "2026.1.23"; | ||
| url = "https://github.com/clawdbot/clawdbot/releases/download/v2026.1.23/Clawdbot-2026.1.23.zip"; | ||
| hash = "sha256-HGN8yfDHkoP30YBk11U7kugE6RVkDs9oGwyUdLztToQ="; | ||
| }; |
There was a problem hiding this comment.
There's significant duplication of the version string (2026.1.23) and related values. It appears in comments, clawdbotAppOverride, and again as clawdbotVersion on line 25. This makes version upgrades brittle, as evidenced by the multiple sed and awk commands in the upgrade-overlays.sh script.
To improve maintainability, consider defining the version and related hashes once in the top-level let block and referencing these variables throughout the file. This would make the code DRY and simplify future upgrades.
There was a problem hiding this comment.
Pull request overview
This is an automated upgrade of the clawdbot overlay from version 2026.1.21 to version 2026.1.23.
Changes:
- Updated clawdbot source override to version v2026.1.23 with new commit SHA and source hash
- Updated clawdbot-app override to version 2026.1.23 with new download URL and hash
- Updated clawdbotVersion variable throughout the file to maintain consistency
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| hash = "sha256-IsTNC79KXKL7ByBh7zUmH6qXx0YFdiQ4a4TI40C53U8="; | ||
| rev = "c9e98376b3e5d3a2f3a1639be53bd850f6d3acbf"; | ||
| hash = "sha256-egAHjt6CHz79fStSg42opVPHjquurAa6FcGpNkQ0UtA="; | ||
| pnpmDepsHash = "sha256-tGzKcCiZNlWlKMNNFmxcFpIvO92G9myhM+OYaGea4hw="; |
There was a problem hiding this comment.
The pnpmDepsHash has not been updated as part of this version upgrade. According to the upgrade script (scripts/upgrade-overlays.sh lines 189-195), if the automated hash computation fails, it keeps the old value and warns that manual verification may be needed. Please verify that the pnpm dependencies genuinely haven't changed between v2026.1.21 and v2026.1.23, or update this hash if needed. An incorrect pnpmDepsHash could cause build failures or fetch incorrect dependencies.
Automated overlay upgrade
Summary by cubic
Upgraded Nix overlays to clawdbot v2026.1.23 by updating the source revision, app package URL, and hashes. This fixes the broken app package and aligns our build with the latest release.
Written for commit a4e9cc7. Summary will update on new commits.