Skip to content

chore(hermes): authorize users in group via group_allowed_chats #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Aug 16, 2026
Merged

chore(hermes): authorize users in group via group_allowed_chats #2393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/hermes/config.template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ whatsapp: {}
telegram:
channel_prompts: {}
require_mention: false
group_allowed_chats: '-1003813578232'
slack:
channel_prompts: {}
mattermost:
Expand Down
1 change: 1 addition & 0 deletions config/hermes/config.tpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ whatsapp: {}
telegram:
channel_prompts: {}
require_mention: false
group_allowed_chats: '-1003813578232'

@indent-zero indent-zero Bot Aug 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer the documented YAML-list form for group_allowed_chats

The hermes public docs (https://hermes-agent.nousresearch.com/docs/user-guide/messaging/telegram) show this key as a list of quoted chat IDs, and upstream PR NousResearch/hermes-agent#76470 ("fix(config): decode JSON array literals into YAML lists on config set") documents the failure mode for scalar values: readers like _coerce_allow_set and the telegram env bridge split scalars on commas, so any non-list value that later contains commas or a JSON literal silently authorizes nothing — the exact bug that PR is closing on the CLI writer side.

A single comma-free ID like '-1003813578232' coerces to a one-element set today, so this works right now. But the moment a second chat is appended (e.g. '-100...,-100...') or tooling emits a JSON literal, authorization silently drops to empty and the group loses access with no error.

Suggested change (apply the same edit in config/hermes/config.template.yaml to keep the templates in lockstep per scripts/llm-update.sh:102):

Suggested change
group_allowed_chats: '-1003813578232'
group_allowed_chats:
- '-1003813578232'

slack:
channel_prompts: {}
mattermost:
Expand Down
Loading