Skip to content

chore(hermes): authorize users in group via group_allowed_chats - #2393

Merged
shunkakinoki merged 1 commit into
mainfrom
chore/telegram-group-allowed-chats
Aug 16, 2026
Merged

chore(hermes): authorize users in group via group_allowed_chats#2393
shunkakinoki merged 1 commit into
mainfrom
chore/telegram-group-allowed-chats

Conversation

@shunkakinoki

@shunkakinoki shunkakinoki commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

Adds telegram.group_allowed_chats: '-1003813578232' to the Hermes config templates so every member of the みうら/Shun group chat is authorized (per gateway authz: authorizes all members of the listed chat regardless of sender). Fixes the "Unauthorized user: 8816096318" rejection that caused Hermes to only react (thumbs-up) instead of replying in that group.

Mirrors #2391 (same 2-template pattern). Requires gateway restart after hydration.

Test plan

  • YAML validated (ruby -ryaml load of both templates)
  • Config hydrates on next nix-switch (kyber); gateway restart activates authz

Summary by cubic

Authorize all members of the みうら/Shun Telegram group in Hermes by adding telegram.group_allowed_chats: '-1003813578232' to both config templates. Previously, Hermes rejected messages from group members and only reacted; now it will reply in that chat. This change authorizes any member of that specific chat.

Rollout

  • Hydrate config and deploy (e.g., run nix-switch), then restart the Hermes gateway.
  • Confirm -1003813578232 is the correct group ID.

Written for commit 46bbc17. Summary will update on new commits.

Review in cubic

@pullfrog

pullfrog Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Run failed. View the logs →

Pullfrog  | Rerun failed job ➔View workflow run | via Pullfrog | Using Claude Opus𝕏

@indent-zero

indent-zero Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Indent Zero is shutting down on August 7th. Please migrate over to Indent 2.0 to continue getting PR reviews.

PR Summary

Adds a single Telegram supergroup to the hermes gateway's group allowlist so members of the みうら group can talk to the bot without individual enumeration. Combined with the previously merged require_mention: false, the bot will now respond to every message in that chat. Both hermes config templates are kept in sync per the scripts/llm-update.sh mapping.

  • Add telegram.group_allowed_chats: '-1003813578232' to config/hermes/config.tpl.yaml (source template) and config/hermes/config.template.yaml (generated artifact).

Issues

1 potential issue found:

CI Checks

Waiting for CI checks...


⚡ Autofix All Issues

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 60f479d9-89d8-4168-8ab2-7472bf0f92a4

📥 Commits

Reviewing files that changed from the base of the PR and between c2cb646 and 46bbc17.

📒 Files selected for processing (2)
  • config/hermes/config.template.yaml
  • config/hermes/config.tpl.yaml

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Configuration
    • Enabled support for an approved Telegram group chat.
    • Updated configuration templates to include the allowed group chat setting.

Walkthrough

The Telegram configuration templates now allow group chat -1003813578232 through group_allowed_chats.

Changes

Telegram configuration

Layer / File(s) Summary
Add Telegram group chat allowlist
config/hermes/config.template.yaml, config/hermes/config.tpl.yaml
Both templates define group_allowed_chats with chat ID -1003813578232.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 46bbc

This localized configuration change authorizes the intended group members and has validated YAML templates; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

Poem

A bunny checked the chat list twice,
And found one group ID precise.
The templates now know where to hop,
Messages land without a stop.
-1003813578232 joins the plot!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Hermes configuration change and the authorized group.
Description check ✅ Passed The description accurately explains the configuration change, its purpose, validation, and rollout requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/telegram-group-allowed-chats

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

telegram:
channel_prompts: {}
require_mention: false
group_allowed_chats: '-1003813578232'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer the documented YAML-list form for group_allowed_chats

The hermes public docs (https://hermes-agent.nousresearch.com/docs/user-guide/messaging/telegram) show this key as a list of quoted chat IDs, and upstream PR NousResearch/hermes-agent#76470 ("fix(config): decode JSON array literals into YAML lists on config set") documents the failure mode for scalar values: readers like _coerce_allow_set and the telegram env bridge split scalars on commas, so any non-list value that later contains commas or a JSON literal silently authorizes nothing — the exact bug that PR is closing on the CLI writer side.

A single comma-free ID like '-1003813578232' coerces to a one-element set today, so this works right now. But the moment a second chat is appended (e.g. '-100...,-100...') or tooling emits a JSON literal, authorization silently drops to empty and the group loses access with no error.

Suggested change (apply the same edit in config/hermes/config.template.yaml to keep the templates in lockstep per scripts/llm-update.sh:102):

Suggested change
group_allowed_chats: '-1003813578232'
group_allowed_chats:
- '-1003813578232'

@shunkakinoki
shunkakinoki merged commit 95f6e61 into main Aug 16, 2026
32 of 34 checks passed
@shunkakinoki
shunkakinoki deleted the chore/telegram-group-allowed-chats branch August 16, 2026 07:01
@shunkakinoki shunkakinoki changed the title chore(hermes): authorize users in みうら group via group_allowed_chats chore(hermes): authorize users in group via group_allowed_chats Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant