Skip to content

fix(hermes): register cliproxy as a proper provider #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shunkakinoki merged 1 commit into from
Aug 10, 2026
Merged

fix(hermes): register cliproxy as a proper provider #2334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion config/hermes/config.template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
model:
default: cliproxy/deepseek-v4-flash
providers: {}
providers:
cliproxy:
base_url: https://cliproxy.shunkakinoki.com/v1
api_key: __CLIPROXY_API_KEY__
api_mode: chat_completions

@indent-zero indent-zero Bot Aug 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate cliproxy definition — the same endpoint is still declared under custom_providers: at lines 329-333 of this file (and the equivalent block in config.tpl.yaml). Upstream hermes_cli/config.get_compatible_custom_providers reads both providers: and custom_providers: and dedupes them by (name, base_url, model), so today they collapse to a single entry — but this is a latent hazard: if either copy gets an edit (base_url, api_mode swap, models list, extra_headers, context_length, enabled: false), the two definitions silently diverge and only the copy the resolver hits first (providers:) wins. Pick a single source of truth — either drop the custom_providers: block below or revert to using it alone (which was already sufficient, see the misdiagnosis note on the commit message).

fallback_providers:
- provider: cliproxy
model: deepseek-v4-pro
Expand Down
6 changes: 5 additions & 1 deletion config/hermes/config.tpl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
model:
default: cliproxy/__DEEPSEEK_FLASH__
providers: {}
providers:
cliproxy:
base_url: https://cliproxy.shunkakinoki.com/v1
api_key: __CLIPROXY_API_KEY__
api_mode: chat_completions
fallback_providers:
- provider: cliproxy
model: __DEEPSEEK_PRO__
Expand Down
Loading